This repository was archived by the owner on Nov 17, 2020. It is now read-only.
Merged
Conversation
Documenting this input will help users avoid confusion over why the ASG fails to populate with lower bandwidth instance types that are set to be EBS Optimized (T2.*, M3.medium, etc). Smaller instance types are likely to be used in DDD for a collection of domain related microservices where as one big Stack of large instances types would make more sense for sharing the Stack among multiple domains.
document ecs_instance_ebs_optimize input var
* Only refactored external/internal subnet variables & availability zones for now.
This commit adds an output to the VPC that includes the routing table ids
Add rtb outputs
This commit preserves the same behavior around stack, but instead allows us to define route associations outside of the stack itself and still use the VPC module. It's due to a known ordering issue in Terraform https://www.terraform.io/docs/providers/aws/r/route.html
vpc: split routes
fixed description for external ELB security group
expose route table ids to root stack module
Refactor to support Terraform 0.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.