Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Comments

Refactor to support Terraform 0.7#40

Merged
yields merged 2 commits intosegmentio:masterfrom
likwid:refactor/terraform07
Oct 9, 2016
Merged

Refactor to support Terraform 0.7#40
yields merged 2 commits intosegmentio:masterfrom
likwid:refactor/terraform07

Conversation

@likwid
Copy link
Contributor

@likwid likwid commented Aug 9, 2016

I wanted to start working on Terraform 0.7 #conversion, so I made a small set of changes, only refactoring to lists for a few variables (internal subnets, external subnets and availability zones).

I am trying to gauge interest in converting more of the stack automation over to Terraform 0.7 to use data sources, and native lists/maps where possible.

I wasn't sure if this was desirable or not, but figured I would test the waters.

likwid added 2 commits August 9, 2016 15:56
* Only refactored external/internal subnet variables & availability zones for now.
@gregwebs
Copy link
Contributor

The list hacks are pretty horrible, definitely a welcome improvement for me. I am using lists on my fork now and I see this warnings about not using data:

  * template_file.cloud_config: using template_file as a resource is deprecated; consider using the data source instead
  * template_file.policy: using template_file as a resource is deprecated; consider using the data source instead

@calvinfo
Copy link
Contributor

I do like this, I haven't gotten a chance to review this in-depth but @yields is moving us to 0.7 internally next week. I think he can help review and ensure everything look good!

@yields yields merged commit 3c0c47d into segmentio:master Oct 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants