This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Refactor to support Terraform 0.7#40
Merged
yields merged 2 commits intosegmentio:masterfrom Oct 9, 2016
likwid:refactor/terraform07
Merged
Refactor to support Terraform 0.7#40yields merged 2 commits intosegmentio:masterfrom likwid:refactor/terraform07
yields merged 2 commits intosegmentio:masterfrom
likwid:refactor/terraform07
Conversation
* Only refactored external/internal subnet variables & availability zones for now.
Contributor
|
The list hacks are pretty horrible, definitely a welcome improvement for me. I am using lists on my fork now and I see this warnings about not using |
Contributor
|
I do like this, I haven't gotten a chance to review this in-depth but @yields is moving us to 0.7 internally next week. I think he can help review and ensure everything look good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to start working on Terraform 0.7 #conversion, so I made a small set of changes, only refactoring to lists for a few variables (internal subnets, external subnets and availability zones).
I am trying to gauge interest in converting more of the stack automation over to Terraform 0.7 to use data sources, and native lists/maps where possible.
I wasn't sure if this was desirable or not, but figured I would test the waters.