This repository was archived by the owner on Jul 3, 2023. It is now read-only.
expose route table ids to root stack module#51
Merged
achille-roussel merged 3 commits intosegmentio:masterfrom Oct 5, 2016
Merged
expose route table ids to root stack module#51achille-roussel merged 3 commits intosegmentio:masterfrom
achille-roussel merged 3 commits intosegmentio:masterfrom
Conversation
achille-roussel
suggested changes
Oct 5, 2016
main.tf
Outdated
| } | ||
|
|
||
| // The external route table ID. | ||
| output "external_route_table" { |
Contributor
There was a problem hiding this comment.
Any reason why this wouldn't be plural as well? Even if there's only one entry it seems like it would be better to have name consistency between the two attributes.
Contributor
Author
There was a problem hiding this comment.
Agreed, change committed below.
achille-roussel
approved these changes
Oct 5, 2016
Contributor
|
👍 thanks for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route table IDs are already exposed by the VPC module.
This way they are exposed by the root module and we can add routes to the tables.