Repository navigation
seals: re-save the two seals left stale on master (Refs #12466) - #13359
Merged
Merged
Conversation
compiler_ZigArityOneTypedLiteral and formula_registry no longer matched their generated code (Spec Guards run 42464928764 on 3f32d4e). Re-saved with a t27c built from master, after seal --verify matched three untouched seals. No spec changed, no --force. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #12466
Re-saves the two seals Spec Guards lists as STALE on master 3f32d4e (run 42464928764):
.trinity/seals/compiler_ZigArityOneTypedLiteral.json(gen_hash_zig, gen_hash_c, gen_hash_verilog).trinity/seals/formula_registry.json(all four gen hashes; spec last changed by 6d40ff9)Method: t27c built from master;
seal --verifyon three untouched seals (c_array_repeat_wrapper, cse_hoist, eye_isi) printed MATCH for every hash first; thenseal --save, no--force. The new hashes equal the "current" values in the CI log. No spec changed. The twinphysics_formula_registry.jsonalready holds the new hashes; its metadata-only churn is left out.Not in scope, seen in the logs:
formula_registry.json [stale](fixed here) plus 7tests-failseals (numeric_Sha256*,t27os_T27osVfCardMain): the hashes hold, the specs' own tests fail.seal --saverefuses those; they need a spec fix, not a re-save.formula_registry.t27does not compile its Zig tests (use of undeclared identifier 'pow', spec.zig:23); the seal recordstests.blocked.🤖 Generated with Claude Code