Repository navigation
specs(golden): reach 100% coverage — fix [str]->[N]str types, add negative-control tests - #13314
Merged
Merged
Conversation
…;} syntax, add negative-control tests All 7 golden specs now pass coverage: tests 7/7, vacuous 7/7, negative-control 7/7, seal 7/7, issue 7/7, gaps 0, coverage 35/35. Fixes: - [str] arrays → [N]str fixed-size arrays (Zig codegen doesn't support [][]const u8 array initialization) - Removed ;} after test blocks (current parser rejects it) - Added negative_control_refutes_* tests to each spec - Re-sealed all 7 golden specs Closes #12913
Contributor
gHashTag
added a commit
that referenced
this pull request
Nov 7, 2026
gHashTag
added a commit
that referenced
this pull request
Nov 7, 2026
…13303) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Nov 8, 2026
…27b compiles it (Refs #13303) #13314 left `pub const MECHANISM_DESCRIPTION : str = [` (three strings typed as one str). t27b refuses it: the native ratchet reports `golden_oracle.t27: ledger pass, now blocked: ExprArrayLiteral` on master 4dfdd26 and on #13305 head 37c0665. The 4cfd2f2 text, which the ledger records as a pass, had `[3]str`. Only that token changes; every test of master's text stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gHashTag
added a commit
that referenced
this pull request
Nov 8, 2026
(Closes #13303) (#13305) * specs: restore golden and shootout syntax undone by #12996/#12997 (Closes #13303) The #12997 and #12996 merges took the old side of an add/add conflict and brought back text of 11 specs that no longer parses (`};` after test blocks, `[...];` after const arrays, `str = [` for string arrays). This restores the text each spec held at 28fd63d, which equals 4cfd2f2 for specs/golden and 53cb6e6 for specs/tri/shootout. The set of test, invariant and assert lines is identical to master's. improve.t27 no longer uses tri::t27b::zig_like_optimization_plan, which 6b8b6ca moved to docs. The restored golden specs hash to the spec_hash already recorded in golden_GoldenSeries.json and golden_GoldenSpiral.json. Closes #13303 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * specs: restore codegen_audit.t27 typed LOSSES undone by #12997 (Closes #13303) The merge turned `LOSSES : [5]Loss` back into an untyped array and dropped the bench `use` and the branch-bound model section. The t27b native ratchet reports the file as "ledger pass, now blocked: ExprArrayLiteral" (run 42406646026). Restore the 73f626b text the ledger records as a pass; every test and name of master's version is kept, 5 tests come back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * specs/golden: take master's #13314 text whole after the merge (Refs #13303) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * specs/golden: type golden_oracle MECHANISM_DESCRIPTION as [3]str so t27b compiles it (Refs #13303) #13314 left `pub const MECHANISM_DESCRIPTION : str = [` (three strings typed as one str). t27b refuses it: the native ratchet reports `golden_oracle.t27: ledger pass, now blocked: ExprArrayLiteral` on master 4dfdd26 and on #13305 head 37c0665. The 4cfd2f2 text, which the ledger records as a pass, had `[3]str`. Only that token changes; every test of master's text stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * seals: re-save golden_GoldenOracle for the [3]str fix (Refs #13303) Re-saved from a T27 OS shell-cell pane with ~/t27/target/release/t27c (built from cb1c1d6, an ancestor of master), on the owner's word for this one seal on #13305. spec_hash ca92a02a5e matches the fixed specs/golden/golden_oracle.t27; tests 5/5, vacuous 0. Not blessed, not added to tools/seal_baseline.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 7 golden specs now pass coverage: tests 7/7, vacuous 7/7, negative-control 7/7, seal 7/7, issue 7/7, gaps 0, coverage 35/35.
Fixes:
Closes #12913