aegisub: Persist config.json#17705
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates the Scoop manifest Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/aegisub.json (1)
1-36: Run local manifest lint + a test install.Before merging, please run Scoop’s manifest lint/verification for
aegisuband do at least one install to confirm persistence behavior:
.\\bin\\checkver.ps1 -App aegisub -f.\\bin\\formatjson.ps1 -App aegisubscoop install .\\bucket\\aegisub.json -a 64bitAlso double-check the committed JSON uses CRLF line endings (Scoop bucket manifests require CRLF). (Based on coding guidelines: Scoop manifest CRLF + local test guidance.)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/aegisub.json` around lines 1 - 36, Run Scoop manifest lint and a local install test for aegisub.json: run .\bin\checkver.ps1 -App aegisub -f, then .\bin\formatjson.ps1 -App aegisub, and finally verify installation with scoop install .\bucket\aegisub.json -a 64bit to confirm persistence behavior; also ensure the committed aegisub.json uses CRLF line endings (convert/save with CRLF) before committing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/aegisub.json`:
- Around line 1-36: Run Scoop manifest lint and a local install test for
aegisub.json: run .\bin\checkver.ps1 -App aegisub -f, then .\bin\formatjson.ps1
-App aegisub, and finally verify installation with scoop install
.\bucket\aegisub.json -a 64bit to confirm persistence behavior; also ensure the
committed aegisub.json uses CRLF line endings (convert/save with CRLF) before
committing.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 19c40240-5bd7-4167-ad00-08acee815a0d
📒 Files selected for processing (1)
bucket/aegisub.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. aegisub
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. aegisub
|
Summary
Aegisub uses config.json to store misc settings. The manifest needs to persist this for most settings to carry over versions. We do not need to create the file ourselves as the portable zip comes with a pre-configured config.
<manifest-name[@version]|chore>: <general summary of the pull request>