Skip to content

aegisub: Persist config.json#17705

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
emotion3459:patch-2
Apr 29, 2026
Merged

aegisub: Persist config.json#17705
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
emotion3459:patch-2

Conversation

@emotion3459

Copy link
Copy Markdown
Contributor

Summary

Aegisub uses config.json to store misc settings. The manifest needs to persist this for most settings to carry over versions. We do not need to create the file ourselves as the portable zip comes with a pre-configured config.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 21041dea-9987-4c97-92c2-cf79f084e818

📥 Commits

Reviewing files that changed from the base of the PR and between a817c5f and ea6d0d9.

📒 Files selected for processing (1)
  • bucket/aegisub.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/aegisub.json

📝 Walkthrough

Walkthrough

Updates the Scoop manifest bucket/aegisub.json: replaces a plain license URL with a structured license object, adds a suggest entry for vcredist2022, and introduces PowerShell lifecycle hooks (pre_install and pre_uninstall) that copy config.json between the app directory and $persist_dir (creating $persist_dir when needed) to preserve user configuration across installs/uninstalls.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: persisting the config.json file for the Aegisub package.
Description check ✅ Passed The description provides a clear summary of the changes and confirms adherence to the repository's conventional PR title and contributing guide requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/aegisub.json (1)

1-36: Run local manifest lint + a test install.

Before merging, please run Scoop’s manifest lint/verification for aegisub and do at least one install to confirm persistence behavior:

  • .\\bin\\checkver.ps1 -App aegisub -f
  • .\\bin\\formatjson.ps1 -App aegisub
  • scoop install .\\bucket\\aegisub.json -a 64bit

Also double-check the committed JSON uses CRLF line endings (Scoop bucket manifests require CRLF). (Based on coding guidelines: Scoop manifest CRLF + local test guidance.)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/aegisub.json` around lines 1 - 36, Run Scoop manifest lint and a local
install test for aegisub.json: run .\bin\checkver.ps1 -App aegisub -f, then
.\bin\formatjson.ps1 -App aegisub, and finally verify installation with scoop
install .\bucket\aegisub.json -a 64bit to confirm persistence behavior; also
ensure the committed aegisub.json uses CRLF line endings (convert/save with
CRLF) before committing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/aegisub.json`:
- Around line 1-36: Run Scoop manifest lint and a local install test for
aegisub.json: run .\bin\checkver.ps1 -App aegisub -f, then .\bin\formatjson.ps1
-App aegisub, and finally verify installation with scoop install
.\bucket\aegisub.json -a 64bit to confirm persistence behavior; also ensure the
committed aegisub.json uses CRLF line endings (convert/save with CRLF) before
committing.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 19c40240-5bd7-4167-ad00-08acee815a0d

📥 Commits

Reviewing files that changed from the base of the PR and between d707c61 and 0186faa.

📒 Files selected for processing (1)
  • bucket/aegisub.json

@emotion3459

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

aegisub

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Comment thread bucket/aegisub.json Outdated
@emotion3459 emotion3459 requested a review from z-Fng April 29, 2026 10:32
@z-Fng z-Fng changed the title aegisub: Persist config.json aegisub: Persist config.json Apr 29, 2026
@z-Fng

z-Fng commented Apr 29, 2026

Copy link
Copy Markdown
Member

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

aegisub

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit b816a44 into ScoopInstaller:master Apr 29, 2026
3 checks passed
@emotion3459 emotion3459 deleted the patch-2 branch April 29, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants