prime95@30.19b20: Persist results.txt & prime.txt#16911
Conversation
WalkthroughAdds Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. prime95
|
`results.txt` is the log file `prime.txt` is the config file
7e400be to
543790f
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/prime95.json (1)
19-19: Pre-install script looks functional, with minor style considerations.The script correctly creates placeholder files for persistence if they don't exist in
persist_dir. However, there are a couple of optional refinements:
- The forward slash in
"/$_.txt"works but results in mixed path separators (e.g.,C:\path\to\dir/results.txt). While PowerShell handles this, using a backslash or omitting the leading separator would be more idiomatic for Windows.New-Itemwithout-ItemType Fileshould default to creating a file, but explicitly specifying-ItemType Fileimproves clarity.- Consider adding
-Forceto handle the edge case where a file might already exist in$dir.These are stylistic suggestions; the current implementation should work correctly.
🔎 Optional refinement
- "pre_install": "$null = 'results','prime' | ForEach-Object { $_ = \"/$_.txt\"; if (!(Test-Path \"$persist_dir$_\")) { New-Item \"$dir$_\" } }", + "pre_install": "$null = 'results','prime' | ForEach-Object { $_ = \"\\$_.txt\"; if (!(Test-Path \"$persist_dir$_\")) { New-Item \"$dir$_\" -ItemType File -Force } }",
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/prime95.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-14T11:15:55.229Z
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), the Model and Engine folders are created at runtime (not included in the installer), so they should only be in the persist list and not in post_install scripts that handle .original directories.
Applied to files:
bucket/prime95.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/prime95.json (2)
27-30: LGTM! Persistence correctly configured.The
persistarray properly declaresresults.txtandprime.txtfor preservation across updates. This aligns with the PR objectives and works in conjunction with thepre_installscript.
31-31: Good improvement to escape literal dots in the regex.Escaping the dots in
\.win64\.zipand\.win32\.zipmakes the regex more precise by matching literal dots instead of wildcards. This reduces the chance of false positives. The updated regex correctly matches the actual download page format where files are namedp95v3019b20.win64.zipandp95v3019b20.win32.zip.
results.txt & prime.txtresults.txt & prime.txt
results.txtis the log file.prime.txtis the config file.<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.