Skip to content

prime95@30.19b20: Persist results.txt & prime.txt#16911

Merged
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
brian6932:prime95/persist-prime-results
Jan 3, 2026
Merged

prime95@30.19b20: Persist results.txt & prime.txt#16911
z-Fng merged 3 commits into
ScoopInstaller:masterfrom
brian6932:prime95/persist-prime-results

Conversation

@brian6932

@brian6932 brian6932 commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

results.txt is the log file.
prime.txt is the config file.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Installer now auto-creates missing result and indicator files/directories during initial setup.
    • User result data is preserved across updates to prevent loss of progress.
    • Version detection tightened to more accurately match expected update archives, reducing update mismatches.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 1, 2026

Copy link
Copy Markdown

Walkthrough

Adds pre_install and persist entries to bucket/prime95.json and tightens the checkver regex to explicitly match \.win64\.zip and \.win32\.zip. Ensures results.txt and prime.txt exist and are preserved across updates.

Changes

Cohort / File(s) Summary
Prime95 manifest
bucket/prime95.json
Added pre_install to create results.txt and prime.txt under persistence if missing; added persist entries for those files; updated checkver regex to escape dots and require \.win64\.zip / \.win32\.zip endings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • HUMORCE

Poem

🐰 I hop and patch the manifest fine,
I make the files and mark them mine,
Dots escaped, the ZIPs align,
Results will keep, primes will shine,
A tiny rabbit's tidy sign!

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: adding persistence for results.txt and prime.txt files in prime95.
Description check ✅ Passed The description includes required checklist items and explains the purpose of the changes, meeting the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 543790f and b4f3aab.

📒 Files selected for processing (1)
  • bucket/prime95.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/prime95.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

prime95

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

`results.txt` is the log file
`prime.txt` is the config file
@brian6932 brian6932 force-pushed the prime95/persist-prime-results branch from 7e400be to 543790f Compare January 1, 2026 07:50

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
bucket/prime95.json (1)

19-19: Pre-install script looks functional, with minor style considerations.

The script correctly creates placeholder files for persistence if they don't exist in persist_dir. However, there are a couple of optional refinements:

  • The forward slash in "/$_.txt" works but results in mixed path separators (e.g., C:\path\to\dir/results.txt). While PowerShell handles this, using a backslash or omitting the leading separator would be more idiomatic for Windows.
  • New-Item without -ItemType File should default to creating a file, but explicitly specifying -ItemType File improves clarity.
  • Consider adding -Force to handle the edge case where a file might already exist in $dir.

These are stylistic suggestions; the current implementation should work correctly.

🔎 Optional refinement
-    "pre_install": "$null = 'results','prime' | ForEach-Object { $_ = \"/$_.txt\"; if (!(Test-Path \"$persist_dir$_\")) { New-Item \"$dir$_\" } }",
+    "pre_install": "$null = 'results','prime' | ForEach-Object { $_ = \"\\$_.txt\"; if (!(Test-Path \"$persist_dir$_\")) { New-Item \"$dir$_\" -ItemType File -Force } }",
📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e400be and 543790f.

📒 Files selected for processing (1)
  • bucket/prime95.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-14T11:15:55.229Z
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), the Model and Engine folders are created at runtime (not included in the installer), so they should only be in the persist list and not in post_install scripts that handle .original directories.

Applied to files:

  • bucket/prime95.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/prime95.json (2)

27-30: LGTM! Persistence correctly configured.

The persist array properly declares results.txt and prime.txt for preservation across updates. This aligns with the PR objectives and works in conjunction with the pre_install script.


31-31: Good improvement to escape literal dots in the regex.

Escaping the dots in \.win64\.zip and \.win32\.zip makes the regex more precise by matching literal dots instead of wildcards. This reduces the chance of false positives. The updated regex correctly matches the actual download page format where files are named p95v3019b20.win64.zip and p95v3019b20.win32.zip.

@z-Fng z-Fng changed the title prime95: Persist results.txt & prime.txt prime95@30.19b20: Persist results.txt & prime.txt Jan 3, 2026

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 0131bb3 into ScoopInstaller:master Jan 3, 2026
3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jan 26, 2026
2 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Feb 10, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants