Skip to content

aegisub-arch1t3cht: Update to version 02-01, fix checkver & autoupdate#17713

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
emotion3459:patch-2
Apr 30, 2026
Merged

aegisub-arch1t3cht: Update to version 02-01, fix checkver & autoupdate#17713
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
emotion3459:patch-2

Conversation

@emotion3459

Copy link
Copy Markdown
Contributor

Summary

The aegisub-arch1t3cht fork has switched to a new version format (migration releases) which are currently being used to migrate users to upstream. This PR fixes the checkver so these new releases are properly caught. Additionally, it applies the same fix as #17576 to persist the catalog folder.

Relates to #17576

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The pull request updates a Scoop manifest file for aegisub by migrating from feature-branch-based releases to migration-numbered releases. The changes include updating the pinned version from 12 to 02-01, modifying the 64-bit portable download URL and associated archive hash, adding a catalog entry to the persistence list, switching version detection from a custom pattern to GitHub's releases API with a new tag regex (migration<major-minor>), and updating the autoupdate URL template to use the new migration$version release path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'aegisub-arch1t3cht: Update to version 02-01' clearly summarizes the main change: updating the manifest to the new version format, matching the PR's primary objective.
Description check ✅ Passed The description includes a clear summary of changes, explains the rationale for the update, references related issue #17576, and confirms compliance with contribution guidelines via checkboxes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
bucket/aegisub-arch1t3cht.json (1)

49-57: Please run the local Scoop validation flow before merge.

scoop config debug true
scoop config gh_token <your-github-token>   # read-only token
.\bin\checkver.ps1 -App aegisub-arch1t3cht -f
.\bin\formatjson.ps1 -App aegisub-arch1t3cht
scoop install .\bucket\aegisub-arch1t3cht.json -a 64bit

References:

As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@bucket/aegisub-arch1t3cht.json` around lines 49 - 57, Run the recommended
local Scoop validation for this manifest: use the checkver/autoupdate entries in
aegisub-arch1t3cht.json (notably the "checkver" block and the autoupdate
"architecture" 64bit URL referencing migration$version) to execute the local
validation flow (enable scoop debug, set gh_token, run .\bin\checkver.ps1 -App
aegisub-arch1t3cht -f, run .\bin\formatjson.ps1 -App aegisub-arch1t3cht, and
then install the manifest with scoop install .\bucket\aegisub-arch1t3cht.json -a
64bit) and fix any issues the validation reports (e.g., regex/url mismatches,
formatting, or download URL resolution) before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@bucket/aegisub-arch1t3cht.json`:
- Around line 49-57: Run the recommended local Scoop validation for this
manifest: use the checkver/autoupdate entries in aegisub-arch1t3cht.json
(notably the "checkver" block and the autoupdate "architecture" 64bit URL
referencing migration$version) to execute the local validation flow (enable
scoop debug, set gh_token, run .\bin\checkver.ps1 -App aegisub-arch1t3cht -f,
run .\bin\formatjson.ps1 -App aegisub-arch1t3cht, and then install the manifest
with scoop install .\bucket\aegisub-arch1t3cht.json -a 64bit) and fix any issues
the validation reports (e.g., regex/url mismatches, formatting, or download URL
resolution) before merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d47f4681-8aae-4996-9a70-51fbc69db62a

📥 Commits

Reviewing files that changed from the base of the PR and between bf63d5d and b279597.

📒 Files selected for processing (1)
  • bucket/aegisub-arch1t3cht.json

@emotion3459

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

aegisub-arch1t3cht

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@emotion3459

Copy link
Copy Markdown
Contributor Author

This check passes locally.

@emotion3459

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

aegisub-arch1t3cht

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng

z-Fng commented Apr 30, 2026

Copy link
Copy Markdown
Member

This version number is no longer semantically increasing, which means users who installed previous versions may not receive updates.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 2f25b1e into ScoopInstaller:master Apr 30, 2026
4 checks passed
@z-Fng z-Fng changed the title aegisub-arch1t3cht: Update to version 02-01 aegisub-arch1t3cht: Update to version 02-01, fix checkver & autoupdate Apr 30, 2026
@emotion3459 emotion3459 deleted the patch-2 branch June 15, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants