aegisub-arch1t3cht: Update to version 02-01, fix checkver & autoupdate#17713
Conversation
📝 WalkthroughWalkthroughThe pull request updates a Scoop manifest file for aegisub by migrating from feature-branch-based releases to migration-numbered releases. The changes include updating the pinned version from Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
bucket/aegisub-arch1t3cht.json (1)
49-57: Please run the local Scoop validation flow before merge.scoop config debug true scoop config gh_token <your-github-token> # read-only token .\bin\checkver.ps1 -App aegisub-arch1t3cht -f .\bin\formatjson.ps1 -App aegisub-arch1t3cht scoop install .\bucket\aegisub-arch1t3cht.json -a 64bitReferences:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines: "Provide clear instructions for testing the manifest locally before submission."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@bucket/aegisub-arch1t3cht.json` around lines 49 - 57, Run the recommended local Scoop validation for this manifest: use the checkver/autoupdate entries in aegisub-arch1t3cht.json (notably the "checkver" block and the autoupdate "architecture" 64bit URL referencing migration$version) to execute the local validation flow (enable scoop debug, set gh_token, run .\bin\checkver.ps1 -App aegisub-arch1t3cht -f, run .\bin\formatjson.ps1 -App aegisub-arch1t3cht, and then install the manifest with scoop install .\bucket\aegisub-arch1t3cht.json -a 64bit) and fix any issues the validation reports (e.g., regex/url mismatches, formatting, or download URL resolution) before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@bucket/aegisub-arch1t3cht.json`:
- Around line 49-57: Run the recommended local Scoop validation for this
manifest: use the checkver/autoupdate entries in aegisub-arch1t3cht.json
(notably the "checkver" block and the autoupdate "architecture" 64bit URL
referencing migration$version) to execute the local validation flow (enable
scoop debug, set gh_token, run .\bin\checkver.ps1 -App aegisub-arch1t3cht -f,
run .\bin\formatjson.ps1 -App aegisub-arch1t3cht, and then install the manifest
with scoop install .\bucket\aegisub-arch1t3cht.json -a 64bit) and fix any issues
the validation reports (e.g., regex/url mismatches, formatting, or download URL
resolution) before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d47f4681-8aae-4996-9a70-51fbc69db62a
📒 Files selected for processing (1)
bucket/aegisub-arch1t3cht.json
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with aegisub-arch1t3cht
|
|
This check passes locally. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. aegisub-arch1t3cht
|
|
This version number is no longer semantically increasing, which means users who installed previous versions may not receive updates. |
Summary
The aegisub-arch1t3cht fork has switched to a new version format (migration releases) which are currently being used to migrate users to upstream. This PR fixes the checkver so these new releases are properly caught. Additionally, it applies the same fix as #17576 to persist the catalog folder.
Relates to #17576
<manifest-name[@version]|chore>: <general summary of the pull request>