Skip to content

aida64extreme: Add aida64.reg.ini, aida64.sst.ini to persistent storage#16757

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
ltguillaume:aida64extreme
Dec 9, 2025
Merged

aida64extreme: Add aida64.reg.ini, aida64.sst.ini to persistent storage#16757
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
ltguillaume:aida64extreme

Conversation

@ltguillaume

@ltguillaume ltguillaume commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

These files contain the program settings and the System Stability Test settings respectively.

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Bug Fixes
    • Installer now ensures multiple required configuration and license files are created if missing, preventing startup issues.
    • Expanded persistence so additional config/report files are preserved across sessions, improving settings continuity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 9, 2025

Copy link
Copy Markdown

Walkthrough

Pre-install steps now ensure three persistence files — aida64.reg.ini, aida64.sst.ini, and pkey.txt — are created if missing, and the persist array was expanded to include Reports, aida64.reg.ini, and aida64.sst.ini alongside existing entries.

Changes

Cohort / File(s) Summary
AIDA64 Configuration
bucket/aida64extreme.json
Replaced single pkey.txt existence check with a loop that ensures aida64.reg.ini, aida64.sst.ini, and pkey.txt exist under persist_dir in pre_install; expanded persist array to include Reports, aida64.reg.ini, and aida64.sst.ini (keeps existing aida64.ini and pkey.txt).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify JSON loop/syntax in pre_install ensures files are created with correct paths.
  • Confirm persist entries are correctly named and ordered (Reports, aida64.reg.ini, aida64.sst.ini, pkey.txt, aida64.ini).
  • Check backward compatibility with existing aida64.ini handling.

Poem

🐰 I hopped into configs, three at a time,
I nudged small files into place and rhyme.
Reports and INIs snug and set,
No file forgotten, none to fret.
A tiny patch — a tidy prime.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context about the added files but lacks issue/PR references and is incomplete compared to the template requirements. Add explicit issue or PR reference (Closes #XXXX or Relates to #XXXX) and expand explanation of why these files need persistence.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding two configuration files to persistent storage for AIDA64 Extreme.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 823e901 and 2a707fd.

📒 Files selected for processing (1)
  • bucket/aida64extreme.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/aida64extreme.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

aida64extreme

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

…to persistent storage

These files contain the program settings and the System Stability Test settings respectively.

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit 6348cd6 into ScoopInstaller:master Dec 9, 2025
3 checks passed
@ltguillaume ltguillaume deleted the aida64extreme branch December 9, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants