Skip to content

msikombustor: Update to version 4.1.36, fix checkver & autoupdate#16718

Merged
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
SorYoshino:msikombustor
Dec 5, 2025
Merged

msikombustor: Update to version 4.1.36, fix checkver & autoupdate#16718
z-Fng merged 1 commit into
ScoopInstaller:masterfrom
SorYoshino:msikombustor

Conversation

@SorYoshino

@SorYoshino SorYoshino commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Summary

Updates msikombustor to version 4.1.36, refines the manifest structure, and improves the update/verification workflow for long-term maintainability.

Related issues or pull requests

Changes

  • Update version to 4.1.36
  • Update homepage to the canonical product page
  • Update download URL and SHA256 hash for the 64-bit installer
  • Update checkver regex
  • Enhance autoupdate:
    • Added dynamic hash retrieval from Geeks3D download page
    • Ensures the manifest remains valid even if upstream packaging changes

Testing

┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App msikombustor -Dir 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket' -f
msikombustor: 4.1.36 (scoop version is 4.1.36)
Forcing autoupdate!
Autoupdating msikombustor
DEBUG[1764845006] [$updatedProperties] = [url hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1764845006] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1764845006] $substitutions.$baseurl                       https://gpuscore.top/msi
DEBUG[1764845006] $substitutions.$match1                        4.1.36
DEBUG[1764845006] $substitutions.$underscoreVersion             4_1_36
DEBUG[1764845006] $substitutions.$basenameNoExt                 MSI_Kombustor4_Setup_v4.1.36_x64
DEBUG[1764845006] $substitutions.$urlNoExt                      https://gpuscore.top/msi/MSI_Kombustor4_Setup_v4.1.36_x64
DEBUG[1764845006] $substitutions.$matchTag                      837
DEBUG[1764845006] $substitutions.$basename                      MSI_Kombustor4_Setup_v4.1.36_x64.exe
DEBUG[1764845006] $substitutions.$matchHead                     4.1.36
DEBUG[1764845006] $substitutions.$preReleaseVersion             4.1.36
DEBUG[1764845006] $substitutions.$url                           https://gpuscore.top/msi/MSI_Kombustor4_Setup_v4.1.36_x64.exe
DEBUG[1764845006] $substitutions.$dashVersion                   4-1-36
DEBUG[1764845006] $substitutions.$dotVersion                    4.1.36
DEBUG[1764845006] $substitutions.$cleanVersion                  4136
DEBUG[1764845006] $substitutions.$majorVersion                  4
DEBUG[1764845006] $substitutions.$buildVersion
DEBUG[1764845006] $substitutions.$matchTail
DEBUG[1764845006] $substitutions.$patchVersion                  36
DEBUG[1764845006] $substitutions.$version                       4.1.36
DEBUG[1764845006] $substitutions.$minorVersion                  1
DEBUG[1764845006] $hashfile_url = https://geeks3d.com/dl/show/837 -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
Searching hash for MSI_Kombustor4_Setup_v4.1.36_x64.exe in https://geeks3d.com/dl/show/837
DEBUG[1764845007] $regex = (?i)sha256.+?([a-fA-F0-9]{64})< -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:78:9
Found: f578cbcc7487596756c6b5c9b3f8419375f5232f087154c8ec318196b871eb65 using Extract Mode
Writing updated msikombustor manifest

┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> scoop install Unofficial/msikombustor
Installing 'msikombustor' (4.1.36) [64bit] from 'Unofficial' bucket
Loading MSI_Kombustor4_Setup_v4.1.36_x64.exe from cache.
Checking hash of MSI_Kombustor4_Setup_v4.1.36_x64.exe ... ok.
Extracting MSI_Kombustor4_Setup_v4.1.36_x64.exe ... done.
Linking D:\Software\Scoop\Local\apps\msikombustor\current => D:\Software\Scoop\Local\apps\msikombustor\4.1.36
Creating shim for 'MSI-Kombustor'.
Making D:\Software\Scoop\Local\shims\msi-kombustor.exe a GUI binary.
Creating shortcut for MSI Kombustor (MSI-Kombustor-x64.exe)
'msikombustor' (4.1.36) was installed successfully!
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Updates

    • Version upgraded to 4.1.36 and 64‑bit installer package refreshed.
    • Project homepage URL updated.
    • Installer metadata now marks the package as using Inno Setup.
  • New/Improved

    • Automated update detection and autoupdate flow enhanced to use structured version parsing and dynamic release/hash retrieval for more reliable updates.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 4, 2025

Copy link
Copy Markdown

Walkthrough

This change updates the msikombustor manifest: bumps version to 4.1.36, updates homepage, promotes innosetup to a top-level boolean, moves bin/shortcuts to top-level, replaces simple checkver with a structured checkver (url + regex/script), and introduces a dynamic autoupdate flow that builds URLs from a matched tag and fetches hashes via a show URL.

Changes

Cohort / File(s) Summary
Manifest metadata update
bucket/msikombustor.json
Version -> 4.1.36; homepage updated; top-level innosetup added; bin/shortcuts migrated to top-level; replaced string checkver with structured object (url, regex, script-based parsing); autoupdate added using $matchTag to construct download URL and a show-URL/regex block to fetch SHA256; 64-bit URL and hash updated; removed explicit "MSI-Kombustor-x64.exe" entry from bin array.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify the new checkver URL and regex correctly capture the release tag on the source page.
  • Confirm the autoupdate $matchTag interpolation produces valid download URLs and the show-URL regex reliably extracts the SHA256.
  • Validate the top-level bin/shortcuts entries match previous runtime behavior and that innosetup placement is correct.

Possibly related PRs

Suggested reviewers

  • z-Fng

Poem

🐰 I hopped through lines and bumped the seed,
Moved flags and bins with nimble speed,
Regex whiskers sniffed the tag,
Autoupdate finds the right download flag,
Kombustor ready — hop, succeed! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description provides a comprehensive summary with related issues, detailed changes, and testing evidence. Both required PR title convention and Contributing Guide checkboxes are marked as completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and concisely summarizes the main changes: version update to 4.1.36 and fixes to checkver & autoupdate functionality.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

msikombustor

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@SorYoshino SorYoshino marked this pull request as draft December 4, 2025 19:30
@SorYoshino SorYoshino marked this pull request as ready for review December 4, 2025 20:24
@z-Fng

z-Fng commented Dec 4, 2025

Copy link
Copy Markdown
Member

Move bin and shortcuts definitions out of the architecture block to match Scoop conventions

The suffix like -x64.exe indicates that this is architecture-specific, so it's better to plac it inside the architecture block.

See also: #2862 (comment)

@z-Fng

z-Fng commented Dec 4, 2025

Copy link
Copy Markdown
Member

Would a simplified version work?

"checkver": {
"url": "https://www.geeks3d.com/yaffplayer/downloads/",
"regex": "dl/show/(?<page>\\d+).*?YAFFplayer\\s+(?<version>[\\d.]+).*?win64"
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://geeks3d.com/dl/get/$matchPage#YAFFplayer_$version_win64.7z",
"hash": {
"url": "https://geeks3d.com/dl/show/$matchPage",
"regex": "SHA256.*?$sha256"
}
}
}
}

@SorYoshino SorYoshino changed the title msikombustor:Update to version 4.1.36, fix checkver & autoupdate, refactor manifest msikombustor:Update to version 4.1.36, fix checkver & autoupdate Dec 5, 2025
@SorYoshino

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

msikombustor

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@SorYoshino

Copy link
Copy Markdown
Contributor Author

The suffix like -x64.exe indicates that this is architecture-specific, so it's better to plac it inside the architecture block.

See also: #2862 (comment)

Done.

@SorYoshino

Copy link
Copy Markdown
Contributor Author

Would a simplified version work?

It works. However, to avoid additional maintenance caused by potential future changes to extract_dir, I will continue using the installer.

@z-Fng z-Fng changed the title msikombustor:Update to version 4.1.36, fix checkver & autoupdate msikombustor: Update to version 4.1.36, fix checkver & autoupdate Dec 5, 2025

@z-Fng z-Fng left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants