msiafterburner: Update to version 4.6.6, fix checkver & autoupdate#16268
Conversation
WalkthroughUpdated the MSI Afterburner manifest: bumped version 4.6.5 → 4.6.6, changed download source to Guru3D, updated hash, replaced multiple specific cleanup/remove calls with a consolidated pre-install cleanup loop, switched profile migration to Copy-Item then remove, and replaced the static checkver with a scripted POST-based fetch/parse and updated autoupdate URL template. Changes
Sequence Diagram(s)sequenceDiagram
participant CI as Checkver Script
participant Guru3D as Guru3D Server
participant Parser as Version/File Extractor
participant Auto as Autoupdate URL
CI->>Guru3D: POST to download endpoint (follow redirects)
Guru3D-->>CI: Redirect / response containing file path
CI->>Parser: Extract version and filename ($matchFile)
Parser-->>Auto: Provide version + file path for autoupdate URL
note right of Auto #dff2d8: Autoupdate URL uses $matchFile template
sequenceDiagram
participant Installer as Scoop install flow
participant Pre as pre_install script
participant MSI as MSI installer payload
participant Post as post_install script
Installer->>Pre: Run consolidated cleanup loop (remove temp dirs/files)
Pre-->>Installer: Cleanup done
Installer->>MSI: Install package (from Guru3D URL)
MSI-->>Installer: Installation complete
Installer->>Post: Copy `AB_Profiles` -> `Profiles`, remove `AB_Profiles` (Force)
Post-->>Installer: Post-install finished
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with msiafterburner
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/msiafterburner.json(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Pull Requests
bucket/msiafterburner.json
[error] 1-1: Hashes check failed. Expected hash does not match downloaded file for MSIAfterburnerSetup.zip during autoupdate (msiafterburner). See log for details: computed hash 10de22e72500fdfbb533b4b048ed52aa88d2661d847eeba7cceec405490ca25a vs expected 201d19005e71ba56fa432b3f555207e1ea190e05c279dfb4711f19520e66abf4.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
SorYoshino
changed the title
|
/verify |
|
All changes look good. Wait for review from human collaborators. msiafterburner
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/msiafterburner.json(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
z-Fng
changed the title
|
Thank you for your previous modifications to the |
2 participants
Summary
This PR fixes the recurring hash mismatch and autoupdate failures caused by MSI's dynamic download URLs. The manifest is now more stable, maintainable, and logically consistent.
Changes
$matchFileextracted fromcheckveroutput for reliable URL updates.pre_installsteps and improved cleanup logic.vcredistto 2022.Some tests are shown below:
Closes #16267
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Chores
Bug Fixes