diagram-designer@1.30.0: Update checkver, fix extraction#16659
Conversation
|
All changes look good. Wait for review from human collaborators. diagram-designer
|
For some reason, the folder structure extracted using Extracting DiagramDesignerSetup.1.30.0.msi ... Could not find 'APPDIR'! (error 16)
At D:\Scoop\apps\scoop\current\lib\core.ps1:824 char:9
+ throw "Could not find '$(fname $from)'! (error $($proc.ExitCo ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo : OperationStopped: (Could not find 'APPDIR'! (error 16):String) [], RuntimeException
+ FullyQualifiedErrorId : Could not find 'APPDIR'! (error 16) |
|
Extras/bucket/protonmail-bridge.json Lines 15 to 18 in c6164d9 |
|
Thank you for reviewing it. I will try to resolve the issue when I have time. |
WalkthroughUpdated Scoop manifest for Diagram Designer: description punctuation fixed, license changed from a string to an object (identifier + URL), checkver changed from a regex string to an object (url + regex), and a PowerShell Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-10-16T13:42:43.224ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Simply adding this script fixes the issue. |
z-Fng
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/diagram-designer.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16328
File: bucket/winutil.json:0-0
Timestamp: 2025-10-13T09:37:06.093Z
Learning: When reviewing code in Scoop manifests, always verify the actual file content if the diff appears incomplete or unusual, as diff context can be truncated or displayed incorrectly. The pattern `[string[]](...).ForEach{...}` is commonly used in post_uninstall scripts across the Extras repository.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugtron.json:18-25
Timestamp: 2025-10-16T13:55:04.356Z
Learning: In Scoop manifests, the `checkver.github` field must be a full URI (e.g., `https://github.com/owner/repo`), not just `owner/repo`. The schema defines it with `"format": "uri"`.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Applied to files:
bucket/diagram-designer.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/diagram-designer.json (3)
3-3: Description formatting improved.
12-17: Verify pre_install approach vs. extract_dir pattern mentioned in PR.The PR description mentions "Adds missing extract_dir" and references protonmail-bridge.json as an example, but this implementation uses a
pre_installscript instead. While the conditional approach handles both msiexec and lessmsi extraction variants (which is pragmatic), please confirm this method aligns with the intended solution and is the recommended pattern for this use case.Additionally, verify that the PowerShell string escaping in line 14 is syntactically correct. The trailing backslash and quote (
\") in the path argument appears unusual and may need validation.
24-27: checkver restructuring looks good.The shift from filename-based version detection to FossHub's structured HTML metadata field is more robust. Testing confirmed successful version detection and the regex pattern for extracting the softwareVersion field appears sound.
Please confirm the regex
"softwareVersion\">([\\d.]+)<successfully matches the FossHub HTML and consistently extracts version numbers across updates (as noted in the PR, the field should be stable).
2 participants
Summary
Improves the diagram-designer manifest by correcting its license information, adding missing metadata, and updating the version detection logic to rely on FossHub’s structured metadata.
Related issues or pull requests
fosshub#16460Changes
Freewarelicense declaration:MITlicense.urlfieldextract_dir(APPDIR) to ensure proper MSI extraction resultscheckverto use FossHub’ssoftwareVersionmetadataNotes
extract_dirfield to resolve the following issue:Testing
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.