rtss@7.3.7: Fix url & checkver by z-Fng · Pull Request #16262 · ScoopInstaller/Extras

z-Fng · 2025-10-03T09:48:22Z

Changes

This PR makes the following changes:

rtss@7.3.7: Fix url & checkver. Encode filename to pass CI and fix installation.

Checking hash of [Guru3D]-RTSSSetup737Build28314.zip ... InvalidOperation: D:\Scoop\apps\scoop\current\lib\download.ps1:734
Line |
 734 |      $actual = (Get-FileHash -Path $file -Algorithm $algorithm).Hash.T …
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | You cannot call a method on a null-valued expression.
ERROR Hash check failed!
App:         extras/rtss
URL:         https://ftp.nluug.nl/pub/games/PC/guru3d/afterburner/[Guru3D]-RTSSSetup737Build28314.zip
Expected:    9b084a8cb3e53ec1a673894d0b66e22b16c9fd8785636b020b2d422f3f2a820e
Actual:

Please try again or create a new issue by using the following link and paste your console output:
https://github.com/ScoopInstaller/Extras/issues/new?title=rtss%407.3.7%3a+hash+check+failed

Related Issues/PRs/Commits

Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
I have read the [Contributing Guide](https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md)

Summary by CodeRabbit

Bug Fixes
- Fixed URL encoding for installer downloads so filenames containing brackets are handled correctly.
Refactor
- Improved update-check parsing to extract version and file path from redirects more reliably while keeping the final download URL unchanged.

coderabbitai · 2025-10-03T09:48:30Z

Walkthrough

Updated the Scoop manifest bucket/rtss.json: checkver now parses the server's 302 redirect Location to extract file_path and file_name, percent-encodes brackets in filenames, and constructs versioned paths; autoupdate regex/path logic adjusted to use the redirect-based generic captured path segment.

Changes

Cohort / File(s)	Summary of Changes
RTSS manifest updates `bucket/rtss.json`	`checkver` now parses the 302 `Location` header to extract `file_path` and `file_name`; percent-encodes brackets in `file_name`; constructs version + `file_path` + '/' + `file_name`; updated `autoupdate` regex/path construction to use a generic captured path segment instead of a fixed full-URL pattern.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant Scoop as rtss.json (checkver/autoupdate)
  participant Server as Download Server

  rect rgba(220,240,255,0.35)
    Note over Scoop,Server: checkver (redirect-parsing)
    User->>Scoop: trigger checkver
    Scoop->>Server: request version URL
    Server-->>Scoop: 302 Redirect (Location: .../<file_path>/<file_name>.exe)
    Scoop->>Scoop: parse Location → file_path, file_name
    Scoop->>Scoop: percent-encode brackets in file_name
    Scoop-->>User: computed version + file_path + "/" + file_name
  end

  rect rgba(240,255,220,0.35)
    Note over Scoop,Server: autoupdate (generic path capture)
    User->>Scoop: trigger autoupdate
    Scoop->>Server: fetch latest redirect
    Server-->>Scoop: 302 Redirect with path
    Scoop->>Scoop: apply generic regex to captured path, rebuild URL
    Scoop-->>User: updated download URL / hashes
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I hopped through redirects with bright delight,
Encoded the brackets to keep names tight.
I parsed the Location, traced every trail,
Rebuilt the paths so updates won't fail.
A rabbit's small fix—manifest gleams at night. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description does not include a proper “Closes #XXXX” or “Relates to #XXXX” directive as specified in the repository’s description template, even though related issue #16256 is mentioned informally; all required checklist items are present but the related-issues directive is missing.	Please add a “Closes #16256” or “Relates to #16256” directive in the description according to the template so that related issues are properly tracked and automatically closed or linked.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly summarizes the main change by specifying the manifest (rtss@7.3.7) and the action (fix URL and checkver), following the repository’s conventional PR title format.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-10-03T09:49:28Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

rtss

Check the full log for details.

z-Fng · 2025-10-03T09:54:13Z

/verify

github-actions · 2025-10-03T09:55:22Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

rtss

Check the full log for details.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1a901f3 and 1c5682e.

📒 Files selected for processing (1)

bucket/rtss.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: WindowsPowerShell

z-Fng · 2025-10-03T10:03:19Z

/verify

github-actions · 2025-10-03T10:04:28Z

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

rtss

Check the full log for details.

z-Fng · 2025-10-03T11:23:51Z

/verify

github-actions · 2025-10-03T11:24:59Z

All changes look good.

Wait for review from human collaborators.

rtss

Check the full log for details.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f6110b and 6e0b391.

📒 Files selected for processing (1)

bucket/rtss.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: WindowsPowerShell

z-Fng · 2025-10-03T11:30:30Z

/verify

github-actions · 2025-10-03T11:33:44Z

All changes look good.

Wait for review from human collaborators.

rtss

Check the full log for details.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e0b391 and dc7f80c.

📒 Files selected for processing (1)

bucket/rtss.json (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: WindowsPowerShell
GitHub Check: PowerShell

github-actions Bot added the manifest-fix-needed label Oct 3, 2025

coderabbitai Bot reviewed Oct 3, 2025

View reviewed changes

Comment thread bucket/rtss.json Outdated

z-Fng force-pushed the fix-rtss branch from 1f6110b to 6e0b391 Compare October 3, 2025 11:23

github-actions Bot added review-needed and removed manifest-fix-needed labels Oct 3, 2025

coderabbitai Bot reviewed Oct 3, 2025

View reviewed changes

Comment thread bucket/rtss.json Outdated

rtss@7.3.7: Fix url & checkver

dc7f80c

z-Fng force-pushed the fix-rtss branch from 6e0b391 to dc7f80c Compare October 3, 2025 11:30

coderabbitai Bot reviewed Oct 3, 2025

View reviewed changes

Comment thread bucket/rtss.json

z-Fng merged commit 8dbe8f2 into ScoopInstaller:master Oct 3, 2025
3 checks passed

z-Fng deleted the fix-rtss branch October 3, 2025 11:38

coderabbitai Bot mentioned this pull request Oct 5, 2025

msiafterburner: Update to version 4.6.6, fix checkver & autoupdate #16268

Merged

2 tasks

coderabbitai Bot mentioned this pull request Jan 20, 2026

geogebra: Update checkver script #17052

Merged

2 tasks

Conversation

z-Fng commented Oct 3, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Related Issues/PRs/Commits

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

github-actions Bot commented Oct 3, 2025

rtss

Uh oh!

z-Fng commented Oct 3, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

rtss

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

z-Fng commented Oct 3, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

rtss

Uh oh!

z-Fng commented Oct 3, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

rtss

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

z-Fng commented Oct 3, 2025

Uh oh!

github-actions Bot commented Oct 3, 2025

rtss

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

z-Fng commented Oct 3, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Oct 3, 2025 •

edited

Loading