Skip to content

Megatron core_r0.19_0 IFU - #159

Open
sudhu2k wants to merge 375 commits into
rocm_devfrom
sudhu/core_r0.19_0_IFU
Open

sudhu2k wants to merge 375 commits into
rocm_devfrom
sudhu/core_r0.19_0_IFU

Conversation

@sudhu2k

@sudhu2k sudhu2k commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

MoE

Model Architecture and Support

Parallelism

Performance and Memory

Precision and Optimizers

Inference

Datasets

Multimodal

Known Issues

  • TE fused cross-entropy may degrade stability: setting cross_entropy_fusion_impl to te causes convergence issues on some models. Use native instead, or upgrade Transformer Engine to 2.18, which carries the fix (TE PR Add absorbed-mla NVIDIA/Megatron-LM#3193).
  • SPCX grouped all-to-all payload corruption at high expert parallelism: in the affected NCCL 2.30.5/SPCX stack, stale or uninitialized ncclIbRequest.send.onlyWriteImm state can misclassify sends in grouped variable-split BF16 all-to-all operations, causing payload loss or corruption. MCore's MoE alltoall dispatcher can expose this issue at high EP configurations, but the fault originates in the SPCX transport rather than the model or router. As a workaround, disable the external NCCL network plugin and use NCCL's internal IB transport (NCCL_NET_PLUGIN=none NCCL_NET=IB), or use the HybridEP dispatcher (Megatron-Bridge issue [Megatron-FSDP] MaxPoolAllocator for double-buffering hybrid architectures. NVIDIA/Megatron-LM#5462).

balasaajay and others added 30 commits June 18, 2026 21:40
)

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
…#5285)

Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
… UVM fixes (NVIDIA#5187)

Signed-off-by: wdykas <wdykas@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…IA#5186)

Signed-off-by: wdykas <wdykas@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Keshav Santhanam <ksanthanam@nvidia.com>
…IA#5286)

Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: shanmugamr1992 <shanmugamr1992@gmail.com>
Signed-off-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>
Co-authored-by: shanmugamr1992 <shanmugamr1992@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Shanmugam Ramasamy <111910568+shanmugamr1992@users.noreply.github.com>
…5375)

Signed-off-by: ykarnati <ykarnati@nvidia.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
…#5468)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
…and remove legacy modelbuilder functions (NVIDIA#5169)

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
svcnemo-autobot and others added 28 commits July 25, 2026 07:18
…VIDIA#6038)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
…A#5997)

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Co-authored-by: Ajay Balasa <abalasa@nvidia.com>
Signed-off-by: Shiqing Fan <shiqingf@nvidia.com>
Signed-off-by: Deepak Narayanan <deepakn94@gmail.com>
Signed-off-by: Jiangfei Duan <jiangfeid@nvidia.com>
Co-authored-by: Jieming Zhang <jiemingz@nvidia.com>
Co-authored-by: Deepak Narayanan <deepakn94@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Jiangfei Duan <jiangfeid@nvidia.com>
Signed-off-by: Philip Monk <pmonk@nvidia.com>
…#6051)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
…ts (NVIDIA#6057)

Signed-off-by: Shiqing Fan <shiqingf@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Philip Petrakian <ppetrakian@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
)

Signed-off-by: Xuanteng Huang <xuantengh@nvidia.com>
…ads with --fp8-param-gather (NVIDIA#4451)

Signed-off-by: asolergi-nv <asolergibert@nvidia.com>
Signed-off-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…eline schedules (NVIDIA#5901)

Signed-off-by: ilml <tolong@nvidia.com>
Signed-off-by: Tom Long <tolong@nvidia.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…NVIDIA#6021)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
…n is the same used during the training iteration (NVIDIA#6048)

Signed-off-by: Deepak Narayanan <dnarayanan@nvidia.com>
Signed-off-by: YangFei1990 <feiw@nvidia.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Siddhartha Raman Sundara Raman <sraman@nvidia.com>
Signed-off-by: kunlunl <kunlunl@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Co-authored-by: kunlunl <kunlunl@nvidia.com>
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
Co-authored-by: Laura Dang <laurad@nvidia.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: William Dykas <wdykas@nvidia.com>
… cold-rank desync

Skip the suite-wide NCCL_MAX_NCHANNELS=1 default on ROCm. With RCCL <= 2.27.7
(ROCm 7.2.x), a low channel cap leaves fewer P2P channels than P2P parts per
peer, so send/recv messages larger than ~32 MB are silently half-delivered.
This corrupted context-parallel attention (test_thd_correctness) and the MoE
dispatcher and custom process-group tests. Fixed upstream in
ROCm/rocm-systems#6307; keep the default for CUDA.

Move TestMoriColdRank out of test_token_dispatcher_mori.py into its own
test_token_dispatcher_cold_rank_mori.py module so the zero-token EP rank case
runs in a fresh torchrun process and a regression there cannot desynchronize
the MORI op and process-group state shared by the other MORI tests.

Signed-off-by: sudhu2k <Sudharshan.Govindan@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@sudhu2k
sudhu2k force-pushed the sudhu/core_r0.19_0_IFU branch from ea6919e to 0c16ef4 Compare October 27, 2026 05:29
@sudhu2k sudhu2k changed the title Sudhu/core r0.19 0 ifu Megatron core_r0.19_0 IFU Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.