Skip to content

fix(dist-ckpt): AUT-1100 restore default strategy factories - #6065

Merged
ko3n1g merged 1 commit into
NVIDIA:mainfrom
svcnemo-autobot:fix/restore-default-save-strategy
Jul 28, 2026
Merged

fix(dist-ckpt): AUT-1100 restore default strategy factories#6065
ko3n1g merged 1 commit into
NVIDIA:mainfrom
svcnemo-autobot:fix/restore-default-save-strategy

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Background

Current verl imports both default distributed-checkpoint strategy factories. Megatron-LM retained only the load symbol, so verl skipped Megatron backend registration.

What changed

  • Restore default load and save strategy factories.
  • Add focused return-type coverage.

Details

The factories construct the current TorchDist*ShardedStrategy implementations. Companion: NVIDIA-NeMo/Megatron-Bridge#5119.

Tested

  • BASE_REF=main CHECK_ONLY=true SKIP_DOCS=false bash tools/autoformat.sh
  • Focused 8-GPU test: 1 passed, 39 deselected on every rank
  • Exact 8-GPU Bridge verl Qwen3, DeepSeek, and MoE scripts with this open commit substituted locally; all TrainJobs succeeded

@svcnemo-autobot
fix(dist-ckpt): restore default strategy factories
8f1f82e 
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested review from a team as code owners July 27, 2026 11:33
@svcnemo-autobot
svcnemo-autobot requested a review from ko3n1g July 27, 2026 11:33
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner July 27, 2026 11:33
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 27, 2026 11:33
@github-actions

github-actions Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnemo-autobot

svcnemo-autobot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 8f1f82e

@svcnemo-autobot svcnemo-autobot mentioned this pull request Jul 27, 2026
Merged
@ko3n1g
ko3n1g marked this pull request as ready for review July 27, 2026 13:19
@svcnemo-autobot

svcnemo-autobot commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/ok to test 8f1f82e

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Jul 27, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Jul 27, 2026
@ko3n1g
ko3n1g enabled auto-merge July 27, 2026 22:38
@ko3n1g
ko3n1g added this pull request to the merge queue Jul 27, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30311503658

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30315002660

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30317254054

Merged via the queue into NVIDIA:main with commit fc57daa Jul 28, 2026
96 of 98 checks passed
@yaoyu-33 yaoyu-33 mentioned this pull request Jul 28, 2026
Closed
4 tasks
shjwudp pushed a commit to shjwudp/Megatron-LM that referenced this pull request Jul 30, 2026
@svcnemo-autobot @shjwudp
fix(dist-ckpt): AUT-1100 restore default strategy factories (NVIDIA#6065
f3d8bc4 
)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@svcnemo-autobot @terminator123
fix(dist-ckpt): AUT-1100 restore default strategy factories (NVIDIA#6065
5d4613c 
)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
@svcnemo-autobot @dimapihtar
fix(dist-ckpt): AUT-1100 restore default strategy factories (NVIDIA#6065
d3ea218 
)

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
@lhb8125 lhb8125 mentioned this pull request Aug 17, 2026
Closed

This branch was previously deployed

2 inactive deployments
public — 8f1f82e2 Deployed Jul 27, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4690
test — 8f1f82e2 Deployed Jul 27, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes
@jiemingz jiemingz jiemingz approved these changes
@ko3n1g ko3n1g Awaiting requested review from ko3n1g

Assignees

No one assigned

Labels

Approved All necessary approvals have been made complexity: low Run functional tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@svcnemo-autobot @svcnvidia-nemo-ci @yaoyu-33 @jiemingz @ko3n1g