Skip to content

send pg group for distributed checkpoint validation - #6092

Merged
wdykas merged 1 commit into
NVIDIA:mainfrom
wdykas:fix/scoped-checkpoint-validation
Jul 28, 2026
Merged

wdykas merged 1 commit into
NVIDIA:mainfrom
wdykas:fix/scoped-checkpoint-validation

Conversation

@wdykas

@wdykas wdykas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

Adds an optional process_group to dist_checkpointing.load().

  • Uses that group for get_world_size() and all_gather_object().
  • Allows each model replica to validate one complete checkpoint view independently.
  • Keeps existing behavior unchanged when no group is provided.

What does this PR do?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

Signed-off-by: William Dykas <wdykas@nvidia.com>
@wdykas
wdykas requested review from a team as code owners July 28, 2026 14:05
@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft July 28, 2026 14:05
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@wdykas wdykas changed the title Scope distributed checkpoint validation send pg group for distributed checkpoint validation Jul 28, 2026
@wdykas
wdykas marked this pull request as ready for review July 28, 2026 14:14
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Jul 28, 2026
@wdykas
wdykas enabled auto-merge July 28, 2026 15:40
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Jul 28, 2026
@wdykas

wdykas commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 40d60dd

@wdykas
wdykas added this pull request to the merge queue Jul 28, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/30388732589

Merged via the queue into NVIDIA:main with commit 818b258 Jul 28, 2026
91 checks passed
@wdykas
wdykas deleted the fix/scoped-checkpoint-validation branch July 28, 2026 20:59
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: William Dykas <wdykas@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Signed-off-by: William Dykas <wdykas@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>

This branch was previously deployed

2 inactive deployments
public — 40d60ddc Deployed Jul 28, 2026 by copy-pr-bot[bot] via finalize / publish-docs #4810
test — 40d60ddc Deployed Jul 28, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #17833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants