Skip to content

Testing: re-enable AOT differential print_r/var_dump array cases (#23540) - #34848

Merged
PurHur merged 1 commit into
masterfrom
fix/differential-aot-print-r-vardump-skips
Aug 25, 2026
Merged

PurHur merged 1 commit into
masterfrom
fix/differential-aot-print-r-vardump-skips

Conversation

@PurHur

@PurHur PurHur commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

Context

Priority queue (#32122, #31968 children) is closed on master. This restores two cases that were incorrectly skipped, raising AOT differential coverage 121/121 → 123/123.

Verification

./script/aot-smoke.sh
# aot-smoke: 8 passed, 0 failed

./script/differential-sweep.sh --aot
# 123/123 match Zend (aot backend)

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/differential/cases/g02_print_r.php; php bin/compile.php -o /tmp/t.bin test/differential/cases/g02_print_r.php && /tmp/t.bin'
# nested print_r output matches VM

./script/docker-exec.sh -- bash -lc 'php bin/vm.php test/differential/cases/e29_var_dump_indent.php; php bin/compile.php -o /tmp/t.bin test/differential/cases/e29_var_dump_indent.php && /tmp/t.bin'
# nested var_dump indent matches VM

Not covered

  • Full ./script/ci-local.sh (LLVM compile gate)
  • north-star5-verify --strict
  • Compliance suite shard diff

Relates to closed #23540, #9190.

Made with Cursor

…#23540)

Stale @differential-skip-aot annotations hid two cases fixed by VarDumpJitHelper
and php-in-PHP print_r lowering; thin standalone AOT now matches Zend.

Co-authored-by: Cursor <cursoragent@cursor.com>
@PurHur
PurHur merged commit ab09556 into master Aug 25, 2026
@PurHur
PurHur deleted the fix/differential-aot-print-r-vardump-skips branch August 25, 2026 23:38
PurHur added a commit that referenced this pull request Aug 25, 2026
…4852)

Drop eager IniRuntime::ensureLinked before thin standalone {main} — JitIni /
IniGet / ZendDoubleStringRuntime already ensureLinked at call sites (peer
#34578 / #34822). Avoids NestedJIT ini ABI drift minting *.1 on cold-build
hello world (#32122 class).

Co-authored-by: PurHur <PurHur@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AOT: var_dump() aborts (SIGABRT) with no diagnostic — even var_dump(7)

1 participant