Testing: re-enable AOT differential print_r/var_dump array cases (#23540) - #34848
Merged
Merged
Conversation
…#23540) Stale @differential-skip-aot annotations hid two cases fixed by VarDumpJitHelper and php-in-PHP print_r lowering; thin standalone AOT now matches Zend. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
added a commit
that referenced
this pull request
Aug 25, 2026
…4852) Drop eager IniRuntime::ensureLinked before thin standalone {main} — JitIni / IniGet / ZendDoubleStringRuntime already ensureLinked at call sites (peer #34578 / #34822). Avoids NestedJIT ini ABI drift minting *.1 on cold-build hello world (#32122 class). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@differential-skip-aotfromg02_print_r.phpande29_var_dump_indent.php.Context
Priority queue (#32122, #31968 children) is closed on master. This restores two cases that were incorrectly skipped, raising AOT differential coverage 121/121 → 123/123.
Verification
Not covered
./script/ci-local.sh(LLVM compile gate)north-star5-verify --strictRelates to closed #23540, #9190.
Made with Cursor