php-in-php: lazy IniRuntime from compileToFile thin path (#34848) - #34852
Merged
Merged
Conversation
Drop eager IniRuntime::ensureLinked before thin standalone {main} — JitIni /
IniGet / ZendDoubleStringRuntime already ensureLinked at call sites (peer
#34578 / #34822). Avoids NestedJIT ini ABI drift minting *.1 on cold-build
hello world (#32122 class).
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IniRuntime::ensureLinkedfromContext::compileToFilefor thin standalone AOT (hello-world / cold-build path).JitIni,IniGet/IniSet,ErrorReporting,ZendDoubleStringRuntime,ExceptionThrowToStringSeed) already lazy-link before lookup — same pattern as php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on CliArgvRuntime — lazy at CliArgvGlobalInit / compileToFile (#32122 class) #34822 CliArgv and php-in-php: drop Context ensureMinimalUserStandaloneBodies always-on StreamLifecycle/StreamRead/StreamBucket — lazy at call sites (peer #34822 / #34439) #34836 Stream* (Release v1.1.0: fix cold-build-check compile_failed on hello world (LLVM Module.php line 180; re-#24302) #32122.1mint class).ContextMinimalStandaloneLazyIniCompileToFileRuntimeShrinkTest.Verification
Not run: full differential sweep (121-case),
north-star5-verify --strict, compliance suites.Made with Cursor