php-in-php: lazy stdlib string/file helpers from Type::String_::implement (#35613) - #35613
Merged
Merged
Conversation
This was referenced Aug 28, 2026
PurHur
added a commit
that referenced
this pull request
Aug 31, 2026
… (#36102) TypeDeadHttpBuildQueryAbiRuntimeShrinkTest still expected eager StringHttpBuildQuery::implement in Type\String_::implement after #35613 moved http_build_query to call-site ensureLinked. Assert lazy wiring instead. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the
#32122/.1 mint classruntime-shrink ladder (peer #35609): drop 21 eager::implement()calls fromType\String_::implement()for stdlib string/file helpers whose ext/ and Jit* call sites alreadyensureLinkedbefore lookup.Removed from full Type init NestedJIT:
Left eager:
StringBitwiseNot(Helper emits inline — needs call-site ensureLinked first, #35301),IniSet/IniGet/ErrorReporting(JitIni get/set + JitErrorReporting still lookup without ensureLinked, #34848), date/time batch (peer #34241).No new
runtime/*.c—RUNTIME_C_SOURCESstays empty.Root cause
Eager NestedJIT during
Type\String_::implement()on the full JIT load path mints duplicate ABI symbols (*.1) when Runtime and Context both link the same helper (#31894 / #32122).Test plan
Not run: full
ci-fast.sh, differential sweep,north-star5-verify-fast(compile-spine stub audit already 0/0 stubbed; change is lazy-link only on full Type init path).Made with Cursor