Trust: dedupe socket_select spine require and sync 5030/5030 footnotes - #19406
Merged
Merged
Conversation
#19401 added socket_select.php twice under merge race, leaving spine 5031/5030 and stale assertSame/README trackers. Restore honest 5030/5030 coverage. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#19401left a duplicateext/sockets/socket_select.phprequire_onceincompiler_lib_spine_smoke(merge race after#19390), so the spine counted 5031/5030.BootstrapSelfhostBundleTestassert to 5030/5030, refresh inventory construct-flag line numbers.Context
Worker lane A had no eligible language/parity issue this run (open
implementation-readyLane A tickets are stdlib/ext/php-in-php/meta). Pillar 1 was red on spine count drift — fixed here instead of claiming another lane.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (5030/5030)php script/check-selfhost-spine-count-sync.php→ OKphp script/bootstrap-inventory.php --check→ OK 5030/5030php script/bootstrap-spine-count.php→ 5030/5030socket_select.phprequire in spine (grep -c→ 1)./script/release-readiness.sh --jsonafter merge (expectuser_release_ready: yes)Refs #19390 #19401 #10533
Made with Cursor