Stdlib: socket_select() via poll(2) thin FFI (#6395) - #19390
Merged
Conversation
Register socket_select with by-ref array write-back and Socket element guards, multiplexing owned fds through SocketsLibcThinAbi::poll. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 16, 2026
Closed
PurHur
added a commit
that referenced
this pull request
Jul 16, 2026
#19390 landed socket_select on the vm.php inventory path without a compiler_lib_spine_smoke require, which red-failed spine-coverage and north-star5-verify-fast. Sync inventory doc to 5030/5030. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
PurHur
added a commit
that referenced
this pull request
Jul 16, 2026
…19399) (#19402) Deferred user-script AOT still cannot nested-compile PregJitHelper (#16075); keep the thin preg_* stubs but house them in ext/standard so lib/JIT/Builtin shrinks. Also add socket_select.php to the spine (trust gate after #19390). Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket_select()inext/sockets(VM) using thin libcpoll(2)viaSocketsLibcThinAbi— no newruntime/C and no hostsocket_selectdelegation.$read/$write/$exceptwrite-back, ZendTypeError/ValueErrormessages, zero-timeout idle/ready onsocket_create_pair.ext/sockets/sockets.cPHP_FUNCTION(socket_select).Closes #6395
Test plan
vendor/bin/phpunit test/compliance/VMTest.php --filter stdlib/socket_selectOKBuiltinByRefParamsTest::testSocketSelectArraysByRefOKsocket_set_nonblock/socket_create_pair)Made with Cursor