Trust: add socket_select.php to selfhost spine (#19390) - #19401
Merged
Merged
Conversation
#19390 landed socket_select on the vm.php inventory path without a compiler_lib_spine_smoke require, which red-failed spine-coverage and north-star5-verify-fast. Sync inventory doc to 5030/5030. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/sockets/socket_select.phpto the vm.php inventory path but omitted thecompiler_lib_spine_smokerequire_once, which red-failed Pillar 1 (spine-coverage+north-star5-verify-fast).docs/bootstrap-inventory.mdto 5030/5030.implementation-readytickets in% 3 == 1are owned by STD Lib / Ext / PHP Runtime (or meta). This is a trust-gate repair so parity workers are unblocked.Test plan
php script/check-selfhost-spine-coverage-sync.php→ OK (5030/5030)php script/bootstrap-inventory.php --check→ OK 5030/5030./script/docker-exec.sh -- bash -lc 'make north-star5-verify-fast'→ OK (fast)./script/release-readiness.sh --json→ confirmuser_release_ready: yesafter this PRRefs: #19390, #10533 (Pillar 1 trust)
Made with Cursor