M2 spine: add stat_.php to compiler_lib_spine_smoke (#1687) - #1795
Closed
PurHur wants to merge 1 commit into
Closed
Conversation
Bundle stat VM/JIT builtin into the self-host spine (447/586 inventory). Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Superseded by #1794 (batch merge already includes stat_.php at 567 units). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ext/standard/stat_.phptocompiler_lib_spine_smoketoward fullbin/vm.phpinventory closure (🔄 North Star 2: Compiler fully compiles itself (living tracker) #1056 / M2 wave 2: Grow compiler_lib_spine_smoke toward full vm.php inventory #1497).BootstrapSelfhostBundleTest.Closes #1687.
Test plan
./script/docker-ci-local.sh fast --filter BootstrapSelfhostBundleTest(3 tests, 334 assertions — includes AOT lint-l)php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php(via unit test)BOOTSTRAP_LIB_SPINE_SMOKE=1 make bootstrap-selfhost-lib-spine-smoke— pre-existing String_.php JIT link failure on harness (also fails on master at 446 units; M2 spine: bundle src/cli.php entry shim (#1432 follow-up) #1467)Made with Cursor