M2 spine: grow compiler_lib_spine_smoke to 567 units (#1056) - #1794
Merged
Conversation
…r 2 (#1056) Add ext/standard inventory wrappers and Vm* helpers to the self-host spine bundle (435→567, ~97% of vm.php inventory). Fix AOT-lint blockers: union types, variadic spreads, PHPDoc type noise, match→switch, and JIT @return docblocks. Explicitly deferred from bundle lint (still registered in Module): VmString, VmSplAutoload, VmPregReplaceCallback, spl_autoload_register, sort/usort/uasort, array_pop/shift/search/combine/multisort, shell_exec. Closes #1056 Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve doc and JitTempnam conflicts; keep 567-unit spine bundle. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compiler_lib_spine_smokefrom 435 → 567require_onceunits (~97% of the 586-file vm.php inventory toward North Star 2).UnionType, variadic spreads,@return Value …prose,match→switchin VmIni/VmString).Deferred from explicit bundle (still Module-registered)
VmString,VmSplAutoload,VmPregReplaceCallback,spl_autoload_register,sort/usort/uasort,array_pop/shift/search/combine/multisort,shell_exec— AOT lint blockers (#1467 follow-ups).Test plan
vendor/bin/phpunit --filter BootstrapSelfhostBundleTest(Docker, LLVM env)php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.php./script/ci-fast.sh --filter BootstrapSelfhostBundleTestCloses #1056
Made with Cursor