Repository navigation
Language: exit(status:)/die(status:) without CLI profile env (#17681) - #17685
Merged
Merged
Conversation
Apply per-compilation-unit language profile from phpc.json languageProfile or a source pragma before preprocess gates, and align supportsExitFunctionForm with other 8.4 forward-profile syntax gates. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 10, 2026
PurHur
added a commit
that referenced
this pull request
Jul 10, 2026
Add lib/LanguageProfileScope.php to compiler_lib_spine_smoke and refresh gen-0 sidecar stamp + bootstrap inventory so ci-fast spine/inventory gates stay green after the per-unit language profile hook landed in Runtime. Co-authored-by: PurHur <PurHur@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanguageProfileScopeto applyphpc.jsonlanguageProfileor a// php-compiler-language-profile=8.4source pragma before preprocess gates (Language: exit(status:)/die(status:) named parameters — parse error without PHP_COMPILER_PROFILE=8.4 (Zend/zend_compile.c) #17681).CompilerVersion::supportsExitFunctionForm()with other 8.4 forward-profile syntax gates (languageProfileVersion()only).exit_die_named_status_84.phpt.Root cause
exit(status:)/die(status:)requiredPHP_COMPILER_PROFILE=8.4on the CLI even when the compilation unit declared a forward profile target. Preprocess rejectors ran before any per-file profile hint could take effect.php-src reference
Zend/zend_compile.c— exit/die named arg parsing (PHP 8.4)ext/standard/basic_functions.c— exit/die handlersPHP implementation
lib/LanguageProfileScope.php— per-unit profile scope (phpc.json + pragma)lib/Web/ProjectManifest.php—resolveLanguageProfile()lib/Runtime.php— scope aroundprepareSourceForParser()lib/CompilerVersion.php— gate alignmentVerification
Closes #17681
Made with Cursor