Repository navigation
Bootstrap: LanguageProfileScope spine coverage + #17681 test guards - #17689
Merged
Merged
Conversation
PR #17685 merged LanguageProfileScope but omitted the self-host spine require; restore coverage sync and add die/pragma compliance + manifest tests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/LanguageProfileScope.phpto the self-host spine (missed in Language: exit(status:)/die(status:) without CLI profile env (#17681) #17685) socheck-selfhost-spine-coverage-sync.phppasses again.die(status:)and source-pragma profile without CLI env.Root cause
PR #17685 introduced
LanguageProfileScopeon thebin/vm.phppath but did not add the spinerequire_once, leaving spine coverage sync red.Verification
Follow-up to Closes #17681 (main fix merged in #17685).
Made with Cursor