Repository navigation
php-in-php: delete StringStripTagsStandaloneLlvm — AOT standalone via StripTagsJitHelper (#9746) - #11174
Merged
Conversation
#9746) Delete ~978-line StringStripTagsStandaloneLlvm LLVM monolith; standalone and JIT now share a thin __compiler_strip_tags bridge into StripTagsJitHelper delegating to VmString::stripTags(). php-src: ext/standard/string.c Co-authored-by: Cursor <cursoragent@cursor.com>
…emoval Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/JIT/Builtin/StringStripTagsStandaloneLlvm.php(~978 lines LLVM) — standalone AOT now uses the same thin__compiler_strip_tagsbridge + compiled PHP helper as JIT (php-in-php: JIT StringStripTagsJit — route strip_tags() through VmString PHP not superglobals_refresh LLVM (#1492) #9196 pattern, php-in-php: AOT LastErrorRuntimeLlvm — route standalone error_get_last through ErrorLastJitHelper PHP not LLVM globals (#1492) #9607/php-in-php: AOT CloneWithReinitRuntimeLlvm — route standalone clone-with reinit through CloneWithJitHelper PHP (#1492) #9717).StripTagsJitHelper::stripTags()delegates toVmString::stripTags()so nested standalone JIT can compile the helper without loop/substr lowering blockers.Closes #9746
php-src reference
ext/standard/string.c—PHP_FUNCTION(strip_tags)/php_strip_tags_exext/standard/VmString.php+StripTagsJitHelper.phpLines removed
StringStripTagsStandaloneLlvm.php(file removed)StripTagsJitHelper.php(now delegates)Verification
Note:
AotTest::testCases strip_tagswas already failing on master (LLVM module verify / session globals) before this change; VM + JIT compliance strip_tags cases remain green.