Skip to content

php-in-php: delete StringStripTagsStandaloneLlvm — AOT standalone via StripTagsJitHelper (#9746) - #11174

Merged
PurHur merged 2 commits into
masterfrom
agent/issue-9746-strip-tags-standalone-php
Jun 24, 2026
Merged

PurHur merged 2 commits into
masterfrom
agent/issue-9746-strip-tags-standalone-php

Conversation

@PurHur

@PurHur PurHur commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #9746

php-src reference

  • ext/standard/string.c — PHP_FUNCTION(strip_tags) / php_strip_tags_ex
  • PHP SSOT: ext/standard/VmString.php + StripTagsJitHelper.php

Lines removed

  • 978 lines deleted from StringStripTagsStandaloneLlvm.php (file removed)
  • ~140 lines removed from self-contained duplicate logic in StripTagsJitHelper.php (now delegates)

Verification

./script/docker-exec.sh -- ./vendor/bin/phpunit --filter 'StripTags|SuperglobalsStripTags'
# OK (5 tests, 14 assertions)

./script/docker-exec.sh -- php bin/jit.php -r 'echo strip_tags("<b>x</b><script>y</script>", "<b>");'
# <b>x</b>y

php script/check-selfhost-spine-coverage-sync.php
# OK (spine covers all 3006 inventory files)

php script/bootstrap-inventory.php --check
# OK 3006/3006

Note: AotTest::testCases strip_tags was already failing on master (LLVM module verify / session globals) before this change; VM + JIT compliance strip_tags cases remain green.

PurHur and others added 2 commits June 24, 2026 07:13
#9746)

Delete ~978-line StringStripTagsStandaloneLlvm LLVM monolith; standalone and JIT
now share a thin __compiler_strip_tags bridge into StripTagsJitHelper delegating
to VmString::stripTags(). php-src: ext/standard/string.c

Co-authored-by: Cursor <cursoragent@cursor.com>
…emoval

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

php-in-php: AOT StringStripTagsStandaloneLlvm — route standalone strip_tags through StripTagsJitHelper PHP not ~980-line LLVM (#1492)

1 participant