php-in-php: JIT StringStripTagsJit — route strip_tags() through VmString PHP not superglobals_refresh LLVM (#1492)

[PurHur]

Category

php-in-php · stdlib

Problem

strip_tags() VM path lives in PHP (ext/standard/strip_tags.php, VmString), but JIT/AOT still emit __compiler_strip_tags plus helper symbols from lib/JIT/Builtin/StringStripTagsJit.php (~900 lines, ported from superglobals_refresh.c tag parser). Enum TypeError parity (#5897) and allowed-tags edge cases must be maintained in one PHP implementation, not a parallel LLVM parser.

php-src reference

• php/php-src ext/standard/string.c — PHP_FUNCTION(strip_tags), php_strip_tags_ex

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php -r "var_export(strip_tags(\"<b>x</b>\", \"<b>\")); echo \"\n\";"
php bin/vm.php -r "var_export(strip_tags(\"<b>x</b>\", \"<b>\")); echo \"\n\";"
php bin/jit.php -r "var_export(strip_tags(\"<b>x</b>\", \"<b>\")); echo \"\n\";" 2>&1
'

VM/JIT should agree; today JIT uses LLVM StringStripTagsJit while VM uses VmString::stripTags().

Scope

Layer	Files
JIT	lib/JIT/Builtin/StringStripTagsJit.php — delegate to compiled VmString / strip_tags builtin
VM reference	ext/standard/VmString.php — single source of truth
Delete/shrink	remove __compiler_strip_tags / __phpc_st_* LLVM helpers when PHP path wired
Tests	test/compliance/cases/stdlib/strip_tags*.phpt; enum operand guard #5897

PHP-in-PHP first: do not extend C tag tables in runtime/; shrink LLVM when PHP lowering is sufficient.

Done when

• JIT/AOT output matches VM on strip_tags compliance tests (including allowed-tags list)
• __compiler_strip_tags LLVM implementation deleted or thin trampoline
• PR notes lines removed from lib/JIT/Builtin/StringStripTagsJit.php
• ./script/ci-fast.sh --filter strip_tags green

Related

• Stdlib: strip_tags() — TypeError for non-string $string (ext/standard/string.c parity) #4593 / Stdlib: strip_tags()/htmlspecialchars() enum case operands must TypeError (ext/standard/string.c, php-src-strict) #5897 — php-src-strict TypeError / enum operands (must stay green)
• php-in-php: JIT StringFormatJit — route sprintf/printf/number_format through VmSprintf not libc LLVM (#1492) #9131 — sprintf php-in-php migration (same LLVM libc pattern)
• North star: Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: PHP Runtime → PHP — starting this run.

[PurHur]

Merged via #9597.

JIT path: __compiler_strip_tags now bridges into compiled StripTagsJitHelper PHP (self-contained parser mirroring VmString::stripTags / php-src string.c).

AOT standalone: LLVM tag parser retained as StringStripTagsStandaloneLlvm.php (gated LOAD_TYPE_STANDALONE; same pattern as LastErrorRuntimeLlvm until native link can host compiled helpers reliably).

Verification (all green on branch):

• Issue repro: Zend / bin/vm.php / bin/jit.php agree on strip_tags('<b>x</b>', '<b>') → '<b>x</b>'
• php vendor/bin/phpunit --filter "StripTags|SuperglobalsStripTags" — OK (4 tests)
• php vendor/bin/phpunit --filter strip_tags_jit — OK (2 tests)
• php vendor/bin/phpunit --filter "AotTest.*strip_tags[^_]" — OK (1 test)