php-in-php: AOT CloneWithReinitRuntimeLlvm — route standalone clone-with reinit through CloneWithJitHelper PHP (#1492)

[PurHur]

Category

php-in-php · runtime

Problem

#9498 (closed) routed JIT embed clone-with readonly reinit through ext/standard/CloneWithJitHelper.php, but AOT standalone still emits CloneWithReinitRuntimeLlvm (~320 lines in lib/JIT/Builtin/CloneWithReinitRuntimeLlvm.php) with property-name string walks in LLVM.

Per PHP-in-PHP strategy: clone reinit semantics belong in ext/standard/CloneWithJitHelper.php + lib/VM/CloneWithSupport.php; AOT should link compiled PHP helpers, not grow lib/AOT/runtime/*.c.

php-src reference

• php/php-src Zend/zend_objects.c — IS_PROP_REINITABLE during clone
• php/php-src Zend/zend_clone.c

Repro (audit today)

wc -l lib/JIT/Builtin/CloneWithReinitRuntimeLlvm.php
rg 'CloneWithReinitRuntimeLlvm' lib/AOT bin/compile.php

Build AOT binary with readonly + clone and confirm LLVM object still references __phpc_clone_with_* symbols from CloneWithReinitRuntimeLlvm instead of CloneWithJitHelper trampolines only.

Minimal runtime script:

<?php
class C {
    public function __construct(public readonly string $v) {}
}
$c1 = new C('a');
$c2 = clone $c1;
echo $c2->v, "\n";

./script/docker-exec.sh php bin/vm.php repro.php          # VM baseline
# AOT: compile repro.php and run; compare behavior + symbol table

Scope

Path	Work
lib/JIT/Builtin/CloneWithReinitRuntime.php	AOT standalone: always prefer compiled CloneWithJitHelper
lib/JIT/Builtin/CloneWithReinitRuntimeLlvm.php	Delete or thin to ABI trampolines only
ext/standard/CloneWithJitHelper.php	SSOT for reinit walk
bin/compile.php / AOT link	Ensure helper prelink like other php-in-php migrations

Done when

• AOT standalone clone-with readonly uses PHP helper path (no property-name LLVM loops)
• wc -l lib/JIT/Builtin/CloneWithReinitRuntimeLlvm.php net decrease documented in PR
• VM + AOT repro prints a; make north-star5-verify-fast green if link path touched
• Reopen/follow-up to closed php-in-php: JIT CloneWithReinitRuntime — route readonly-clone reinit through VmCloneWith PHP not LLVM (#1492) #9498 documented in PR

Related

• Closed php-in-php: JIT CloneWithReinitRuntime — route readonly-clone reinit through VmCloneWith PHP not LLVM (#1492) #9498 · php-in-php: JIT ReadonlyRaise — route readonly property write errors through Vm PHP not ~385-line LLVM (#1492) #9522 ReadonlyRaise LLVM · lib/VM/CloneWithSupport.php · Epic Epic: Self-host critical path — compiler compiles itself (M3→M5) #1492

[PurHur]

claim: worker-lane-c — starting this run

[PurHur]

Merged via #9932.

Change: AOT standalone clone-with readonly reinit now uses compiled CloneWithJitHelper.php (same as JIT embed #9498). Deleted CloneWithReinitRuntimeLlvm.php (~320 LLVM lines).

Verification:

vendor/bin/phpunit test/unit/CloneWithReinitRuntimeShrinkTest.php
php bin/vm.php test/compliance/cases/language/clone_with_readonly.phpt
make bootstrap-selfhost-vm-driver-execute-probe

→ 2 tests OK; clone_with_readonly prints 2; VM driver probe OK; Llvm file absent.