php-in-php: route JIT strip_tags through StripTagsJitHelper (#9196) - #9597
Merged
Merged
Conversation
JIT modules call compiled StripTagsJitHelper PHP (mirrors VmString::stripTags) instead of the default LLVM tag parser; AOT standalone keeps StringStripTagsStandaloneLlvm until native link can host compiled helpers reliably (LastErrorRuntime pattern). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__compiler_strip_tagsthrough compiledStripTagsJitHelperPHP (self-contained tag parser mirroringVmString::stripTags, php-srcext/standard/string.c).StringStripTagsJit.php→StringStripTagsStandaloneLlvm.phpand gate toLOAD_TYPE_STANDALONEonly (AOT native link; same pattern asLastErrorRuntime/LastErrorRuntimeLlvm).StringStripTags.php; add shrink/standalone unit guards.php-src reference
ext/standard/string.c—PHP_FUNCTION(strip_tags),php_strip_tags_exext/standard/VmString.php(VM); JIT runtime:ext/standard/StripTagsJitHelper.phpC runtime shrink
lib/JIT/Builtin/StringStripTagsJit.phpremoved from default JIT link (renamed/gated to standalone-onlyStringStripTagsStandaloneLlvm.php)lib/JIT/Builtin/StringStripTags.php→ compiled PHP helperVerification
Closes #9196
Made with Cursor