Stdlib: strip_tags() — TypeError for non-string $string (ext/standard/string.c parity)

[PurHur]

Category

stdlib

Problem

strip_tags() in Zend throws TypeError when $string is not a string. This compiler raises LogicException (strip_tags() only supports strings in this compiler build) on VM and JIT paths (ext/standard/strip_tags.php).

The second argument $allowed_tags must also throw TypeError when neither string nor null (Zend allows null).

php-src reference

• ext/standard/string.c — PHP_FUNCTION(strip_tags)
• ext/standard/basic_functions.stub.php

Repro (failure today)

<?php
declare(strict_types=1);

function expect_type_error(callable $fn): void {
    try {
        $fn();
        echo "no throw\n";
    } catch (TypeError $e) {
        echo "TypeError\n";
    } catch (Throwable $e) {
        echo get_class($e), ':', $e->getMessage(), "\n";
    }
}

expect_type_error(fn () => strip_tags([]));
expect_type_error(fn () => strip_tags(new stdClass()));
expect_type_error(fn () => strip_tags(123));
expect_type_error(fn () => strip_tags('ok', []));
echo strip_tags('<b>x</b>'), "\n";

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
php repro_strip_tags_type.php
php bin/vm.php repro_strip_tags_type.php
php bin/jit.php repro_strip_tags_type.php
'

Call	Zend PHP 8.x	This compiler VM/JIT
strip_tags([])	TypeError	LogicException
strip_tags(new stdClass())	TypeError	LogicException
strip_tags(123)	TypeError	LogicException
strip_tags('ok', [])	TypeError	LogicException
strip_tags('<b>x</b>')	x	OK

Scope (this repo)

Module	Path
VM	ext/standard/strip_tags.php
JIT/AOT	lib/JIT/Builtin/Type.php / __compiler_strip_tags in lib/AOT/runtime/
Tests	test/repro-maintainer/parity_strip_tags_type.php, new test/compliance/cases/stdlib/strip_tags_type.phpt

Use shared TypeError throw helpers from other stdlib parity issues (#4578 wordwrap pattern).

Done when

• All four invalid calls above throw TypeError on VM and JIT/AOT
• Happy-path strip_tags('<b>x</b>') still prints x
• ./script/ci-fast.sh --filter strip_tags green

Verification

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit --filter strip_tags'

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Unclaiming: strip_tags() TypeError parity already green on master via VmString::coerceStringBuiltinArg / JitStringBuiltinArg. VM repro matches Zend for array/object/int operands on $string. Note: strip_tags('ok', []) is valid in Zend (array allowed_tags per #5053), not TypeError. Compliance: builtin_void_return_validates.phpt, html_enum_typeerror.phpt. Recommend closing as duplicate unless repro differs.

[PurHur]

claim: PHP Compiler STD Lib — starting this run

[PurHur]

Merged via #18139.

Verification (docker-exec):

• `php bin/vm.php test/repro/maintainer_gap_strip_tags_strict_types.php` → three `TypeError` lines + `x`
• `vendor/bin/phpunit --filter strip_tags_strict_types` → OK (VM + JIT compliance)
• Non-strict `strip_tags(123)` still coerces to `123`

VM uses `InternalStrictArg::requireString()` under caller `strict_types`; JIT uses `JitStringBuiltinArg::lowerStrictOrCoercible()`. php-src ref: `ext/standard/string.c`.