php-in-php: Bz2StreamRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #22399 SysGetloadavgRuntime / #22370 GethostbyaddrRuntime)

Problem

lib/JIT/Builtin/Bz2StreamRuntime.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for Bz2StreamJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

Keep NestedJitCompileScope::isActive() early-return in implement() (skip bridge emission during nested helper compile) — only delete the hand-rolled compile body.

php-src reference

• php/php-src ext/bz2/bz2.c — bzopen/bzread/bzwrite/… (semantics unchanged; compile-path only)

PHP implementation target

• lib/JIT/Builtin/Bz2StreamRuntime.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled; use lookupCompiled; drop unused use PHPCompiler\JIT
• test/unit/Bz2StreamRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/Bz2StreamRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

• Bz2StreamRuntime uses JitVmHelperLink::ensureCompiled only for helper compile
• Shrink unit test green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites lines removed

Refs #1492, #17301, #22399, #22370

[PurHur]

claim: PHP Runtime → PHP — starting this run (#22416 Bz2StreamRuntime NestedJIT → JitVmHelperLink::ensureCompiled).

Gates before claim:

Gate	Status	Symptom
bootstrap-inventory --check	red	openssl construct-flag drift (VmOpenssl 68→70) — Lane B claimed restamp
bootstrap-selfhost-link	partial	stale gen-0 fingerprint → Zend fallback (in progress)
north-star5-fast / release-readiness	red	4f-m lowering_source_fingerprint mismatch (#8713) — not this change

Pillar 1 trust red is owned by Lane B; this run is NestedJIT compile-path shrink only (no gen-0 / inventory).

[PurHur]

Merged via #22418

• Bz2StreamRuntime helper compile → JitVmHelperLink::ensureCompiled only
• Net −19 lines in lib/JIT/Builtin/Bz2StreamRuntime.php (no new C)
• Verification: Bz2StreamRuntimeShrinkTest OK; bootstrap-selfhost-vm-driver-execute-probe OK; inventory OK 6432/6432; spine sync OK

[PurHur]

Confirmed merged — squash commit c533446 via #22418

Rebased onto master after #22417 inventory conflict; regenerated docs/bootstrap-inventory.md.

Verification (post-rebase):

• Bz2StreamRuntimeShrinkTest OK (2 tests)
• inventory OK 6432/6432