Skip to content

php-in-php: GethostbyaddrRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492) #22370

Description

@PurHur

Category

php-in-php · runtime-shrink (#1492, peer #22355 CheckdnsrrRuntime / #22313 PasswordRandomBytesRuntime)

Problem

lib/JIT/Builtin/GethostbyaddrRuntime.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for GethostbyaddrJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

php-src reference

PHP implementation target

  • lib/JIT/Builtin/GethostbyaddrRuntime.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled; use lookupCompiled; drop unused use NestedJitCompileScope / use JIT
  • test/unit/GethostbyaddrRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/GethostbyaddrRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

  • GethostbyaddrRuntime uses JitVmHelperLink::ensureCompiled only
  • Shrink unit test green
  • make bootstrap-selfhost-vm-driver-execute-probe green
  • PR body cites lines removed

Refs #1492, #9474, #22355, #22313

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:compilerCompiler / CFG / JITenhancementNew feature or requestimplementation-readySpec complete: repro, php-src ref, done-when — safe for workers to claimphase-0:FoundationPhase 0 – foundation & DevEx

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions