php-in-php: SysGetloadavgRuntime NestedJIT → JitVmHelperLink::ensureCompiled (#1492)

[PurHur]

Category

php-in-php · runtime-shrink (#1492, peer #22370 GethostbyaddrRuntime / #22355 CheckdnsrrRuntime)

Problem

lib/JIT/Builtin/SysGetloadavgRuntime.php still hand-rolls NestedJitCompileScope::run + parseAndCompile + new JIT() for SysGetloadavgJitHelper.php. Peer runtimes route helper compile through JitVmHelperLink::ensureCompiled for consistent user-script env clearing, insert-block restore, and helper-runtime cache.

php-src reference

• php/php-src ext/standard/basic_functions.c — PHP_FUNCTION(sys_getloadavg) (semantics unchanged; compile-path only)

PHP implementation target

• lib/JIT/Builtin/SysGetloadavgRuntime.php — replace ensureJitHelperCompiled body with JitVmHelperLink::ensureCompiled; use lookupCompiled; drop unused use NestedJitCompileScope / use JIT
• test/unit/SysGetloadavgRuntimeShrinkTest.php — guard JitVmHelperLink::ensureCompiled, no hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT(

Repro

./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && vendor/bin/phpunit test/unit/SysGetloadavgRuntimeShrinkTest.php'
make bootstrap-selfhost-vm-driver-execute-probe

Done when

• SysGetloadavgRuntime uses JitVmHelperLink::ensureCompiled only
• Shrink unit test green
• make bootstrap-selfhost-vm-driver-execute-probe green
• PR body cites lines removed

Refs #1492, #12106, #22370, #22355

[PurHur]

claim: PHP Runtime → PHP — starting this run (#22399 SysGetloadavgRuntime NestedJIT → JitVmHelperLink::ensureCompiled). Skipped #22397 Gethostbynamel (peer claim).

[PurHur]

Note: shared worktree briefly had WIP on agent/issue-22399-sys-getloadavg-ensurecompiled; stashed as stash@{0}: wip-peer-22399-sys-getloadavg while finishing claimed #22397 (Gethostbynamel). Restore with git checkout agent/issue-22399-sys-getloadavg-ensurecompiled && git stash pop if needed.

[PurHur]

Implementing on agent/issue-22399-sys-getloadavg-ensurecompiled (isolated worktree — shared checkout was mid-#22397).

• Deleted hand-rolled NestedJitCompileScope::run / parseAndCompile / new JIT( in SysGetloadavgRuntime
• Uses JitVmHelperLink::ensureCompiled + lookupCompiled
• Net -53 lines in lib/JIT/Builtin/SysGetloadavgRuntime.php (11+/64−)
• Host: vendor/bin/phpunit test/unit/SysGetloadavgRuntimeShrinkTest.php → OK (3 tests)
• Next: Docker probe + PR merge

[PurHur]

Merged via #22402

• SysGetloadavgRuntime → JitVmHelperLink::ensureCompiled only
• Net −53 lines in lib/JIT/Builtin/SysGetloadavgRuntime.php (no new C)
• Verification: SysGetloadavgRuntimeShrinkTest OK; bootstrap-selfhost-vm-driver-execute-probe OK; inventory OK 6417/6417