Repository navigation
php-in-php: route StringQuotemeta through JitVmHelperLink::ensureBridge (#1492) #21589
Description
Category
php-in-php · runtime-shrink (#1492, peer #21362 / #21399 / #21579)
Problem
lib/JIT/Builtin/StringQuotemeta.php still hand-rolls NestedJitCompileScope::run + new JIT($context)->compile (~150 LOC bridge boilerplate) instead of the shared JitVmHelperLink::ensureBridge path used by StringSoundex (#21362) and StringChunkSplit (#21399). Same NestedJIT QuotemetaJitHelper SSOT — only the link glue is duplicated.
php-src reference
- php/php-src ext/standard/string.c —
PHP_FUNCTION(quotemeta)
PHP implementation target
lib/JIT/Builtin/StringQuotemeta.php— replace hand-rolled NestedJIT loop withJitVmHelperLink::ensureBridge(Soundex/ChunkSplit shape)test/unit/QuotemetaRuntimeShrinkTest.php— assertensureBridge, noparseAndCompile/new JIT(- Net shrink: delete ~80 LOC of duplicated NestedJIT glue
Repro
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh
vendor/bin/phpunit --filter QuotemetaRuntimeShrinkTest
vendor/bin/phpunit --filter quotemeta
'Done when
-
StringQuotemetausesJitVmHelperLink::ensureBridgeonly - No hand-rolled
NestedJitCompileScope::run/new JIT(in StringQuotemeta - Shrink + quotemeta AOT/compliance green
-
make bootstrap-selfhost-vm-driver-execute-probegreen - PR body cites lines removed
Activity
PurHur commentedon Jul 20, 2026
claim: PHP Runtime → PHP — starting this run
Pillar 1: inventory was RED (hash_hmac construct flags); regenerated → OK 6201/6201. release-readiness still running. Implementing StringQuotemeta → JitVmHelperLink::ensureBridge (Soundex #21362 peer).
php-in-php: route StringQuotemeta through JitVmHelperLink::ensureBrid…
PurHur commentedon Jul 20, 2026
Merged via #21590 (squash).
Verification: QuotemetaRuntimeShrinkTest OK · quotemeta compliance (7) OK ·
make bootstrap-selfhost-vm-driver-execute-probeOK. Net −103 LOC; hand-rolled NestedJIT glue deleted.Note: standalone AOT quotemeta/soundex segfault after
c:main_before_phpis pre-existing on master (same host); not a regression from this PR.Stdlib: Reflection::getModifierNames() + register Reflection class (#…
Stdlib: Reflection::getModifierNames() + register Reflection class (#…