Repository navigation
Stdlib: Reflection::getModifierNames() + register Reflection (#22127) - #22153
Merged
PurHur merged 1 commit intoJul 22, 2026
Merged
Conversation
3 tasks
…22127) Register php-src's Reflection utility class and map modifier bitmasks to name lists (abstract/final/virtual/PPP/PPP_SET/static/readonly). Also route StringQuotemeta through ensureLinked so NestedJIT no longer calls a private implement() after #21589. Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/advanced-stdlib-22127-reflection-get-modifier-names
branch
from
July 22, 2026 11:03
0d216bc to
1d73564
Compare
PurHur
deleted the
agent/advanced-stdlib-22127-reflection-get-modifier-names
branch
July 22, 2026 11:03
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reflectionclass with staticgetModifierNames(int): array(php-src-strict;zim_Reflection_getModifierNames).String_.phpcallsStringQuotemeta::ensureLinked()(implement is private).Closes #22127
php-src reference
ext/reflection/php_reflection.c—zim_Reflection_getModifierNamesext/reflection/php_reflection.stub.php—class ReflectionPHP implementation
ext/standard/VmReflection.php—reflectionGetModifierNames()lib/VM/Builtin/ReflectionGetModifierNames.phplib/VM/BuiltinClasses.php— registerReflectionTest plan
./script/docker-exec.sh -- bash -lc 'source script/php-env.sh && php bin/vm.php test/repro/maintainer_reflection_get_modifier_names.php'vendor/bin/phpunit --filter reflection_get_modifier_names(VM + JIT)php script/bootstrap-inventory.php --check→ OK 6359/6359./script/check-generated-docs.sh→ OKVerification transcript
Made with Cursor