Skip to content

CI: Default THROWSWEB_AOT_LINK_GATE + THROWSWEB_AOT_SMOKE_GATE in ci-local after #2101 #2135

Description

@PurHur

Problem

#2101 will wire opt-in THROWSWEB_AOT_LINK_GATE / THROWSWEB_AOT_SMOKE_GATE for examples/007-ThrowsWeb (pattern from 006 #2011 / #2012).

Without a follow-up flip, throw/catch AOT regressions stay manual until someone runs phpc build by hand — unlike 006 execute smoke which is default-on on master.

Goal

When #2101 PHPUnit + harness curls are green:

  1. script/ci-defaults.envTHROWSWEB_AOT_LINK_GATE=1, THROWSWEB_AOT_SMOKE_GATE=1 (default-on)
  2. script/ci-local.sh llvm group runs link + native execute without extra env
  3. docs/local-ci-matrix.md + phpc doctor --gates document opt-out (=0 for LLVM-less hosts)

Implementation hints

Piece Path Notes
Defaults script/ci-defaults.env Mirror FILE_UPLOAD_WEB_AOT_SMOKE_GATE flip
CI wire script/ci-local.sh, script/ci-common.sh After ThrowsWebAot* tests green
Doctor lib/Doctor.php Row exists via #2102 — update default column
Docs examples/007-ThrowsWeb/README.md Gate table default 1

Verify before flip

THROWSWEB_AOT_LINK_GATE=1 THROWSWEB_AOT_SMOKE_GATE=1 ./script/ci-local.sh \
  --filter 'ThrowsWebAot'

docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  env THROWSWEB_AOT_LINK_GATE=1 THROWSWEB_AOT_SMOKE_GATE=1 ./script/ci-local.sh \
  --filter ThrowsWebAot

Acceptance criteria

  • Default ./script/ci-local.sh runs 007 AOT link+execute when LLVM present (or skips with clear message)
  • THROWSWEB_AOT_*_GATE=0 documented for fast iteration
  • No .github/workflows/* changes

Dependencies

  • #2101 — opt-in gates + tests land first
  • #195 / #57 / #2084 — language + PHPTs
  • #2093 — VM smoke before AOT default-on

Links

  • #2104examples-aot-smoke.sh 007 slice
  • #2124 — deploy smoke (later)
  • ROADMAP #78

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions