Skip to content

Testing: deploy-smoke.sh 007 slice + THROWSWEB_DEPLOY_SMOKE_GATE #2124

Description

@PurHur

Problem

005-SessionsWeb and 006-FileUploadWeb have script/deploy-smoke.sh --example 00x + opt-in *_DEPLOY_SMOKE_GATE ladders (#1893, #2028). 007-ThrowsWeb is on master (#2076 ✅) but deploy-smoke usage/docs stop at 006 and make deploy-smoke-all (#2077) has no 007 row.

Presenters cannot verify phpc deploy + PHPC_DEPLOY_ROOT CGI for caught invalid POST without hand-rolled env.

Scope

Piece Path Notes
Smoke script script/deploy-smoke.sh --example 007; POST invalid email → HTML contains invalid
Env gate script/ci-defaults.env, script/ci-common.sh THROWSWEB_DEPLOY_SMOKE_GATE=0 opt-in first
Make Makefile Optional examples-throwsweb-deploy-smoke (mirror #2044)
Doctor lib/Doctor.php --gates Row after #2101 AOT execute green
Deploy-all Extend #2085 / deploy-smoke-all Print skip hint when gate 0

Depends on: #2101 (THROWSWEB_AOT_* link/execute) for meaningful AOT binary; VM-only deploy slice may land earlier if phpc deploy works on VM-built tree.

Acceptance criteria

# After LLVM + #2101 green:
THROWSWEB_DEPLOY_SMOKE_GATE=1 ./script/deploy-smoke.sh --example 007
docker run --rm -v "$(pwd):/compiler" -w /compiler php-compiler:22.04-dev \
  bash -lc 'THROWSWEB_DEPLOY_SMOKE_GATE=1 ./script/deploy-smoke.sh --example 007'
  • Exit 0; output shows caught invalid POST under PHPC_DEPLOY_ROOT
  • test/unit/DeploySmokeTest.php (or extend existing) asserts gate wiring
  • docs/local-ci-matrix.md documents gate + opt-in ci-local follow-up issue

No GitHub Actions required — verify with ./script/ci-local.sh or Docker above.

Links

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions