Repository navigation
fix(desktop): name the DMG from the display name - #9526
Merged
Merged
Conversation
The DMG file and its volume title now use DESKTOP_DISPLAY_NAME, so a Paradev build ships Paradev-<version>-<arch>.dmg. Unset, names stay Superset. The release keeps the Superset-<arch>.dmg alias beside the new one, since the README, docs and download button link to it. The .app bundle and the -mac.zip update files keep the Superset name. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DESKTOP_DISPLAY_NAME. A Paradev build shipsParadev-<version>-<arch>.dmg(canary:Paradev-Canary-…). With the variable unset, every name staysSuperset.release-desktop.ymluploads bothParadev-<arch>.dmgand the oldSuperset-<arch>.dmgalias. The README, docs, andDOWNLOAD_URL_*(download button) still link to the old alias.What does not change
.appbundle staysSuperset.app.productNamealso sets userData, logs, the keychain entry and the in-place update path.-mac.zipfiles andlatest-mac.ymlkeep their names, so auto-update is not affected.Follow-up
After the first release with the new alias, move
DOWNLOAD_URL_*and the README/docs links toParadev-*.dmg.Verification
Paradev-1.30.0-{arm64,x64}.dmg: it creates bothParadev-andSuperset-copies, and x64 is detected correctly.Paradev; the names and titles are correct.🤖 Generated with Claude Code
Summary by cubic
Names the DMG file and its mounted volume from
DESKTOP_DISPLAY_NAMEso a Paradev build shipsParadev-<version>-<arch>.dmg; with the variable unset, names staySuperset. The release workflow still publishes aSuperset-<arch>.dmgalias for the README, docs, and download button..appbundle,-mac.zipupdate files, andlatest-mac.ymlkeep the Superset name, so auto-update is unaffected.Written for commit b7dca63. Summary will update on new commits.