[akshatcoder-hash]

Fixes #8962

Problem

mapCheckRunStatus in pull-request-mappers.ts has no STARTUP_FAILURE case. A check run that GitHub reports as COMPLETED with that conclusion falls to the default branch and comes out as pending, so computeChecksStatus keeps the pull request pending. The workflow never started, so GitHub shows that check run as a failure, and the mobile client already maps this conclusion to failed.

Changes

• Map STARTUP_FAILURE to failure in mapCheckRunStatus, next to TIMED_OUT and ACTION_REQUIRED.
• Add two tests: the check status from parseCheckContexts, and the aggregate from parseCheckContexts plus computeChecksStatus.
• Leave mapStatusContextState and STALE untouched.

Tests

• pull-request-mappers.test.ts before the fix: 12 pass, 2 fail, both new tests. After the fix: 14 pass, 0 fail.
• cd packages/host-service && bun test --pass-with-no-tests --parallel with bun 1.4.3: 2683 pass, 8 todo, 3 fail. The three failures are the terminal router integration tests that need a real pty daemon, and the same three fail on main.
• A parallel run also times out at the 5 s limit on one or two unrelated tests now and then. Those tests pass in other runs and on main, so the extra timeout is run ordering, not this change. A run just now had only the three pty daemon failures.
• biome check and biome format on the changed files report no issues. bun run typecheck is red on main because of unrelated @superset/trpc errors, and this change adds no new errors.

Checklist

• PR title follows conventional commits (type(scope): subject)
• bun run lint and bun run typecheck pass (CI fails on lint warnings too). Lint passes on the changed files. Typecheck fails on main in @superset/trpc and is unrelated to this change.
• "Allow edits from maintainers" is checked on fork PRs
• I have signed the CLA (the bot asks on your first PR)

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5aed3deb-7bbc-42fc-9e7b-d2a92a841f01

Commits

Reviewing files that changed from the base of the PR and between 3c59928 and 91bc4d1.

Files selected for processing: 2

• packages/host-service/src/runtime/pull-requests/utils/pull-request-mappers/pull-request-mappers.test.ts
• packages/host-service/src/runtime/pull-requests/utils/pull-request-mappers/pull-request-mappers.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The check-run mapper now treats GitHub’s STARTUP_FAILURE conclusion as failure. Tests cover the parsed check status and aggregate pull request checks status.

Changes: Check-run failure mapping

Layer / File(s)	Summary
Map startup failures and verify aggregate status packages/host-service/src/runtime/pull-requests/utils/pull-request-mappers/pull-request-mappers.ts, packages/host-service/src/runtime/pull-requests/utils/pull-request-mappers/pull-request-mappers.test.ts	STARTUP_FAILURE maps to failure. Tests verify the parsed check status and aggregate status.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: kitenite

Merge Risk: Minimal · up to 91bc4

No actionable merge-blocking risk is evident in this change.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title "fix(host-service): treat a check run that failed to start as a failure" follows conventional commit format and states the primary change: a check run with STARTUP_FAILURE is now reported as…
Linked Issues check		Issue #8962 has one coding requirement: a completed check run with conclusion STARTUP_FAILURE must map to status failure, and the aggregate checks status must be failure. The reviewed head adds `case …
Out of Scope Changes check		The whole-PR diff against the merge base contains two files. In pull-request-mappers.ts, the change is one added case "STARTUP_FAILURE": line that returns "failure", which directly implements #8962.…
Description check		The description explains the problem, the code changes, test coverage, known unrelated failures, and checklist status. It uses Problem and Changes headings instead of the template's What & why heading…

Full details: Title check

Explanation

The title "fix(host-service): treat a check run that failed to start as a failure" follows conventional commit format and states the primary change: a check run with STARTUP_FAILURE is now reported as failure. The diff maps STARTUP_FAILURE to failure in mapCheckRunStatus and adds tests for it, which matches the title.

Full details: Linked Issues check

Explanation

Issue #8962 has one coding requirement: a completed check run with conclusion STARTUP_FAILURE must map to status failure, and the aggregate checks status must be failure. The reviewed head adds case "STARTUP_FAILURE": next to TIMED_OUT and ACTION_REQUIRED in mapCheckRunStatus (pull-request-mappers.ts), which returns "failure". Before this change, the value fell through to default and returned "pending". parseCheckContexts passes the check run's status and conclusion to mapCheckRunStatus, so the per-check status is now failure. computeChecksStatus returns "failure" when any check has status failure, so the aggregate is also failure. The PR adds two tests in pull-request-mappers.test.ts. One asserts parseCheckContexts returns { name: "build", status: "failure", url: null } for a STARTUP_FAILURE run. The other asserts that computeChecksStatus over that result returns "failure". These tests match the issue's expected results. The issue's reproduction steps (opening the PR in the review tab) are manual and not coding requirements. I read the code and test diff only. I did not execute the tests, so test results rely on the author's report.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against the merge base contains two files. In pull-request-mappers.ts, the change is one added case "STARTUP_FAILURE": line that returns "failure", which directly implements #8962. In pull-request-mappers.test.ts, the change adds a type import for GitHubCheckContextNode, adds a parseCheckContexts import, adds a checkRun fixture helper, and adds a describe("parseCheckContexts") block with two tests. All of these support the new tests for #8962. No other code changed. mapStatusContextState and the STALE handling are unchanged, as the PR description states and the diff confirms. No unrelated changes were found.

Full details: Description check

Explanation

The description explains the problem, the code changes, test coverage, known unrelated failures, and checklist status. It uses Problem and Changes headings instead of the template's What & why heading, but it provides the required information. The How I tested it content is complete.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] This change appears safe to merge.

Summary

The host now treats a completed GitHub check with STARTUP_FAILURE as failed instead of pending.

• Pull-request checks count failed workflow starts as failures.

_{Reviews (1) · Last reviewed commit: "fix(host-service): treat a check run tha..." · Reviewed by Greptile}

[akshatcoder-hash]

I have read the CLA Document and I hereby sign the CLA

[Kitenite]

Thanks! Verified the new tests fail without the fix and pass with it.