Repository navigation
chore: move the admin dashboard to the private superset-sh/admin repo - #8374
Merged
Merged
Conversation
The admin app and the server code only it used (business, growth and analytics.getInsightResults, their PostHog/Mercury/Stripe Sigma/Search Console clients and the metric cache) now live in superset-sh/admin, deployed as the Vercel project superset-admin behind Vercel Authentication. admin.superset.sh already points there, and the new app serves its own tRPC, so nothing calls these procedures any more. - Drop the deploy-admin jobs, the preview comment row, and the Mercury and Search Console env the API no longer needs. - The hourly MRR/NRR refresh moved to a Vercel cron in the new repo; the QStash schedule for /api/analytics/jobs/refresh-mrr can be deleted. - star-history stays here for marketing's starchart, and fetchWithTimeout stays for account purge. admin.setMyPassword and admin.deleteUser stay. - Lingui no longer extracts apps/admin; the catalogs lose only its strings. The private app keeps English text as its fallback.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This PR removes the admin dashboard and its server code from the public repository, and the supplied changes look internally consistent. The author reports passing lint, i18n and tests, and that the admin app is already served from a separate project. No concrete merge-blocking risk was found. After merge, the author's listed cleanup steps still apply: delete the QStash schedule and the old admin Vercel project. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly and concisely describes the primary change: moving the admin dashboard to the private superset-sh/admin repository. It also follows conventional commit format. Description check The description is detailed and relevant. It explains why the admin dashboard is moving, lists the removed and retained functionality, documents post-merge actions, and reports testing results. It doe…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (2 skipped: 2 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
-
📝 Generate docstrings
-
-
-
-
-
-
- Commit to this branch
- Create a new PR
-
-
-
-
-
🧪 Generate unit tests (beta)
-
-
- Commit to this branch
- Create a new PR
-
-
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Preview update published for development build |
Contributor
 |
Contributor
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
#8369 added `bun hiring` and admin-access while this was open. The script, its args helper and the web-url check go to superset-sh/admin with the hiring router (it now calls admin.superset.sh with an API key). The verified-email rule stays here in adminProcedure.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The admin dashboard shows revenue, burn, cash and ARR. This moves it, and the server code only it used, out of this public repo into the private superset-sh/admin repo.
admin.superset.shis served by the new Vercel projectsuperset-admin. Every URL needs a Vercel team login (Vercel Authentication on all deployments), and the app also checks for an@superset.shsession.business.*,growth.*oranalytics.getInsightResultsany more. Desktop, mobile and CLI never called them.What this PR removes
apps/adminbusinessandgrowthrouters,analytics.getInsightResults, and their clients: PostHog insights and HogQL, Mercury, Stripe Sigma, Search Console, Discord and GitHub stats, the metric cache./api/analytics/jobs/refresh-mrrjob. The new repo runs it as an hourly Vercel cron.deploy-adminjobs in production and preview, the admin row in the preview comment, and the Mercury and Search Console env the API no longer reads.apps/adminfrom Lingui extraction. The catalogs lose only admin strings: 9,724 lines deleted, nothing added, no missing translations.Hiring
#8367, #8368 and #8369 landed the hiring pipeline while this was open. Its UI, its router (
hiring.*), the Notion import script andbun hiringmove to superset-sh/admin too (superset-sh/admin#3).bun hiringnow calls admin.superset.sh with an API key. The verified-email rule (hasAdminAccess) stays here inadminProcedure. Thehiring_*tables stay inpackages/db.What stays
star-history, used by marketing's starchart (moved tolib/star-history.ts).fetchWithTimeout, used by account purge (lib/fetch-with-timeout.ts).admin.deleteUserandadmin.setMyPassword.NEXT_PUBLIC_ADMIN_URL, because auth still trusts the admin origin.After merge
/api/analytics/jobs/refresh-mrr.adminVercel project and theVERCEL_ADMIN_PROJECT_IDandNEXT_PUBLIC_SENTRY_DSN_ADMINsecrets.Checks
check:i18npass.main. CI typecheck onmainpasses, so CI on this PR is the real check.Removing these files from
maindoes not remove them from git history.Summary by cubic
Moves the admin dashboard and the server code only it used out of this public repo into the private
superset-sh/adminrepo.admin.superset.shis already live from the new Vercel projectsuperset-admin, which serves its own tRPC, so nothing here callsbusiness.*,growth.*, oranalytics.getInsightResultsany more.Removed
apps/admin, thebusiness,growth, andhiringrouters,analytics.getInsightResults, their PostHog, Mercury, Stripe Sigma, Search Console, Discord and GitHub clients, and the metric cache.bun hiringscript, its args helper, and the web-url check, which now calladmin.superset.shwith an API key./api/analytics/jobs/refresh-mrrjob, now an hourly Vercel cron in the new repo.deploy-adminjobs, the admin preview-comment row, and the Mercury and Search Console env vars.Kept:
star-historyfor marketing's starchart,fetchWithTimeoutfor account purge,admin.deleteUserandadmin.setMyPassword, the verified-email rule inadminProcedure, andNEXT_PUBLIC_ADMIN_URL.After merge
/api/analytics/jobs/refresh-mrr, the oldadminVercel project, and theVERCEL_ADMIN_PROJECT_IDandNEXT_PUBLIC_SENTRY_DSN_ADMINsecrets.Written for commit c166d23. Summary will update on new commits.
Summary by CodeRabbit