Repository navigation
fix(desktop): one 1px border between the panes and the sidebar - #6777
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe change adjusts workspace sidebar dimensions and removes conditional active-pane border styling. It also documents the ChangesWorkspace layout styling
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized styling change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Open a file editor next to another pane and the divider beside it grew to 3px. The pane box drew a 2px border that turned from transparent to border-coloured when the pane took focus, and that border sat directly against the 1px line its neighbour already drew: the split ResizableHandle on one side, the right sidebar's ResizablePanel border on the other. The pane no longer draws that border. PaneHeader already dims to 60% opacity on the panes that are not focused, so the focused pane is still readable, and every seam is now a single 1px line. The sidebar's top strip also stepped down from the pane tab bar. The PR action header was h-12 against the tab bar's h-10, so the two horizontal borders landed 9px apart at the divider. The header is now h-10, and the sidebar tab row is pulled up one pixel so its top border shares a screen row with the tab bar's bottom border. Verified against a running dev build over CDP: both border bands report [39, 40], and the two seams measure 1px where they measured 3px before. Claude-Session: https://claude.ai/code/session_01AWpYhSNQVyCQWUfuJ4X5bP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a file leads to some "double" borders. It leads to a lot of variance in the different border styles used in the app. There is also a misalignment (shown below) that is fixed.
Top strip alignment
Pane seams
Full window
Before:
After:
https://claude.ai/code/session_01AWpYhSNQVyCQWUfuJ4X5bP
Summary by cubic
Ensure a single 1px seam between panes and the right sidebar, and align the sidebar header with the pane tab bar. Old: focused panes drew a 2px border beside a 1px divider (3px seam) and the sidebar header sat lower; New: panes draw no box border, seams are 1px, headers align at 40px; focus is indicated by header opacity.
packages/panesPane; rely onPaneHeaderdimming inactive panes.PRActionHeadertoh-10to match the TabBar height inpackages/panes.-mt-pxtoSidebarHeaderso its top border shares a row with the tab bar’s bottom border.mosaic-theme.cssis unchanged.Written for commit fb96411. Summary will update on new commits.
Summary by CodeRabbit