Skip to content

fix(desktop): restore active pane border - #6818

Merged
Kitenite merged 1 commit into
mainfrom
restore-active-pane-borde
Aug 24, 2026
Merged

Kitenite merged 1 commit into
mainfrom
restore-active-pane-borde

Conversation

@Kitenite

@Kitenite Kitenite commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

What & why

Restore the active-pane border removed in #6777. The highlight only appears when a tab has two or more panes, so a solo pane remains borderless.

How I tested it

  • bun run --filter @superset/panes typecheck
  • bun run --filter @superset/panes test (100 passing)
  • CDP on the real desktop renderer: opened a single terminal pane and confirmed its 2px border is transparent; used the visible Split pane control and confirmed the inactive pane remains transparent while the active pane uses border-primary/15.

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (package-scoped typecheck passed; CI will run the full checks)
  • "Allow edits from maintainers" is checked on fork PRs (not a fork PR)

Summary by cubic

Restores the active-pane border in the desktop renderer to make focus obvious in split views. Previously panes had no border; now only the active pane in a split shows a subtle 2px border, while single-pane tabs remain borderless.

  • Review notes: Change is localized to packages/panes (@superset/panes). Pane.tsx always renders a 2px border and toggles color to border-primary/15 when the pane is active and the tab is split; otherwise it stays border-transparent to avoid layout shift. Validate by splitting a tab: only the active pane should show the border; inactive and single-pane states should remain borderless.

Written for commit ab0a7bc. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Improved the active pane’s appearance in split layouts with a border and partial highlight.
    • Added a smooth color transition when pane states change.
    • Preserved the transparent border for inactive panes.

@Kitenite
Kitenite merged commit 57f7d2a into main Aug 24, 2026
12 of 13 checks passed
@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

🔗 Preview Links

Service Status Link
Neon Database (Neon) ✅ View Branch
Vercel API (Vercel) ✅ Open Preview
Vercel Web (Vercel) ✅ Open Preview
Vercel Marketing (Vercel) ✅ Open Preview
Vercel Admin (Vercel) ✅ Open Preview
Vercel Docs (Vercel) ✅ Open Preview

Preview updates automatically with new commits

@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b4736961-5de5-47be-b763-0398a8753e8e

📥 Commits

Reviewing files that changed from the base of the PR and between b088880 and ab0a7bc.

📒 Files selected for processing (1)
  • packages/panes/src/react/components/Workspace/components/Tab/components/Pane/Pane.tsx

📝 Walkthrough

Walkthrough

The pane container now uses a permanent border. Active panes within split layouts receive a primary-tinted border. Other panes use a transparent border. A color transition animation applies to the border.

Changes

Pane styling

Layer / File(s) Summary
Active pane border styling
packages/panes/src/react/components/Workspace/components/Tab/components/Pane/Pane.tsx
The pane container adds border and transition classes. The border uses the primary color when the pane is active within a split layout and remains transparent otherwise.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: 0x962

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch restore-active-pane-borde

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch was previously deployed

1 inactive deployment
preview — ab0a7bc1 Deployed Aug 24, 2026 by Kitenite via Deploy API #8385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant