Repository navigation
fix(desktop): restore active pane border - #6818
Merged
Merged
Conversation
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pane container now uses a permanent border. Active panes within split layouts receive a primary-tinted border. Other panes use a transparent border. A color transition animation applies to the border. ChangesPane styling
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Restore the active-pane border removed in #6777. The highlight only appears when a tab has two or more panes, so a solo pane remains borderless.
How I tested it
bun run --filter @superset/panes typecheckbun run --filter @superset/panes test(100 passing)border-primary/15.Checklist
type(scope): subject)bun run lintandbun run typecheckpass (package-scoped typecheck passed; CI will run the full checks)Summary by cubic
Restores the active-pane border in the desktop renderer to make focus obvious in split views. Previously panes had no border; now only the active pane in a split shows a subtle 2px border, while single-pane tabs remain borderless.
packages/panes(@superset/panes).Pane.tsxalways renders a 2px border and toggles color toborder-primary/15when the pane is active and the tab is split; otherwise it staysborder-transparentto avoid layout shift. Validate by splitting a tab: only the active pane should show the border; inactive and single-pane states should remain borderless.Written for commit ab0a7bc. Summary will update on new commits.
Summary by CodeRabbit