Skip to content

fix(desktop): one 1px border between the panes and the sidebar #6777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saddlepaddle merged 1 commit into from
Aug 23, 2026
Merged

fix(desktop): one 1px border between the panes and the sidebar #6777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ace/$workspaceId/components/WorkspaceSidebar/components/PRActionHeader/PRActionHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export function PRActionHeader({
const action = selectActionButton(state);

return (
<div className="@container flex h-12 shrink-0 items-center gap-2 bg-muted/45 px-2 dark:bg-muted/35">
<div className="@container flex h-10 shrink-0 items-center gap-2 bg-muted/45 px-2 dark:bg-muted/35">
<div className="drag h-full min-w-0 flex-1" />
<div className="flex items-center gap-2">
<V2WorkspaceOpenInButton workspaceId={workspaceId} />
Expand Down
2 changes: 1 addition & 1 deletion ...space/$workspaceId/components/WorkspaceSidebar/components/SidebarHeader/SidebarHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export function SidebarHeader({
const actions = tabs.find((t) => t.id === activeTab)?.actions;

return (
<div className="flex h-10 shrink-0 items-stretch">
<div className="-mt-px flex h-10 shrink-0 items-stretch">
<div className="flex min-w-0 flex-1 items-center h-full overflow-hidden">
{tabs.map((tab, index) => {
const isActive = activeTab === tab.id;
Expand Down
9 changes: 2 additions & 7 deletions packages/panes/src/react/components/Workspace/components/Tab/components/Pane/Pane.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ interface PaneComponentProps<TData> {
pane: PaneType<TData>;
isActive: boolean;
registry: PaneRegistry<TData>;
// null only for a solo pane (the layout root)
parentDirection?: "horizontal" | "vertical" | null;
paneActions?:
| PaneActionConfig<TData>[]
Expand Down Expand Up @@ -245,13 +246,7 @@ export function Pane<TData>({
{/* biome-ignore lint/a11y/noStaticElementInteractions: clicking anywhere in a pane focuses it (standard IDE behavior) */}
<div
ref={setRefs}
// parentDirection is null only for a solo pane (layout root), which
// needs no focus outline.
className={`relative flex h-full w-full ${PANE_MIN_SIZE_CLASS_NAME} flex-col overflow-hidden border-2 transition-colors duration-150 ${
isActive && parentDirection !== null
? "border-primary/15"
: "border-transparent"
}`}
className={`relative flex h-full w-full ${PANE_MIN_SIZE_CLASS_NAME} flex-col overflow-hidden`}
onMouseDown={context.actions.focus}
>
<PaneHeader
Expand Down