Repository navigation
feat(desktop): restyle sidebar with a cleaner, denser look - #5944
Conversation
Soft foreground-wash fill tokens (--fill-hover/--fill-selected), inset rounded rows, muted icons, uppercase Projects micro-label, keycap shortcut hints, and a collapsed rail that continues the pane tab bar on the v2 workspace route (TopBar stays hidden on cmd+B). Claude-Session: https://claude.ai/code/session_01VTufk27JQRoonNcZFiCUvx
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds shared sidebar hover and selection tokens, reusable keyboard shortcut hints, broad sidebar styling updates, and v2 workspace chrome integration that renders navigation controls in the tab bar when the collapsed sidebar is open. ChangesSidebar and workspace chrome
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant DashboardLayout
participant V2WorkspacePage
participant Workspace
participant TabBar
DashboardLayout->>V2WorkspacePage: hide TopBar when collapsed sidebar hosts chrome
V2WorkspacePage->>Workspace: provide renderTabBarLeading
Workspace->>TabBar: forward leading renderer
TabBar->>V2WorkspacePage: render SidebarToggle and NavigationControls
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
VscNewFolder/VscFolderOpened hover swap on add-repository buttons, longer tooltip delay, smaller icon, Projects label at full muted color, collapsed New Workspace square keeps its fill. Claude-Session: https://claude.ai/code/session_01VTufk27JQRoonNcZFiCUvx
# Conflicts: # apps/desktop/src/renderer/routes/_authenticated/_dashboard/layout.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/panes/src/react/components/Workspace/components/TabBar/TabBar.tsx`:
- Around line 223-238: Keep the add-button width consistent with the subtree
measured by OverflowFadeContainer: update the TabBar render logic around
AddTabButton and hasHorizontalOverflow so the measured overflow track reserves
the same 40px space in both overflow states, or move the button outside that
measured container permanently. Preserve the existing button behavior while
preventing hasHorizontalOverflow from oscillating.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: ba7ed6d8-141e-44eb-b16c-5ae002406cf9
📒 Files selected for processing (4)
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsxapps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspacesHeader/DashboardSidebarWorkspacesHeader.tsxpackages/panes/src/react/components/Workspace/components/TabBar/TabBar.tsxpackages/panes/src/react/components/Workspace/components/TabBar/components/TabItem/TabItem.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarHeader/DashboardSidebarHeader.tsx
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
|
Ready to review this PR? Stage has broken it down into 6 individual chapters for you: Chapters generated by Stage for commit fb77bde on Jul 25, 2026 2:55am UTC. |
Reorder add-repo menu (open-from-folder first, GitHub icon on clone), and shrink/thin the main nav icons to lighten their optical weight. Claude-Session: https://claude.ai/code/session_01VTufk27JQRoonNcZFiCUvx
3bb6c70 to
fb77bde
Compare
Summary
Restyles the desktop sidebar (v2
DashboardSidebar, with matching color treatment in the legacy v1WorkspaceSidebar):--fill-hover/--fill-selected— low-opacity foreground washes viacolor-mix, so they track every theme. All sidebar active/hover fills (bg-muted,bg-accent) migrate to them.mx-2 rounded-md) with the soft wash as the active state; the active-row stripe is removed (section accent stripes stay).SidebarKbdHint) replace the fading mono text on New Workspace / Search; visibility-toggled so rows never shift on hover.renderTabBarLeadingslot in@superset/paneshosts the traffic-light inset plus the sidebar/nav controls.Test plan
https://claude.ai/code/session_01VTufk27JQRoonNcZFiCUvx
Summary by cubic
Restyles the desktop sidebar for a denser, cleaner UI. On v2 workspaces, the collapsed rail continues the pane tab bar and hosts window/nav controls, so the TopBar stays hidden when the sidebar is open.
New Features
--fill-hoverand--fill-selectedtokens; migrated hover/active fills across v2 and legacy sidebars.SidebarKbdHint; shown on hover without layout shift.renderTabBarLeadingin@superset/panesinjectsSidebarToggle+NavigationControlswhen the rail is collapsed.VscFolderOpened,VscGithubAlt,VscNewFolder,VscLayoutwith hover swap; lighter/smaller nav icons.Bug Fixes
@superset/panes: include the add-tab button width in overflow measurement to keep the tab bar layout stable.Written for commit fb77bde. Summary will update on new commits.
Summary by CodeRabbit