Repository navigation
fix(desktop): remove empty top strip on automations, tasks, and workspaces views - #6023
Conversation
…paces views With the expanded v2 sidebar hosting the traffic lights and nav, the TopBar rendered as a fully empty 48px strip above these views. Hide it there (matching the workspace and new-workspace routes) and add window-drag filler leaves to each view's own header so the window stays draggable. Claude-Session: https://claude.ai/code/session_015PEPRDMRZobovARaZiBHgd
|
Ready to review this PR? Stage has broken it down into 4 individual chapters for you:
Chapters generated by Stage for commit 4787b8f on Jul 28, 2026 8:22pm UTC. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughDashboard routes now hide the TopBar across additional views and render draggable placeholder regions in automation, task, issue, pull request, and workspace headers. ChangesDashboard TopBar drag regions
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
…ests views Extends the hidden-TopBar treatment from ParadevAI#6023 to the new /pull-requests route: the layout hides the strip there, and the pull-requests toolbar and shared work-item detail header carry the window-drag filler leaves. Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb
* feat(desktop): separate tasks and pull requests in sidebar * fix(desktop): re-measure task title height on text change, drop dead stored-search seed Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb * fix(desktop): hide the empty TopBar and keep window drag on pull-requests views Extends the hidden-TopBar treatment from #6023 to the new /pull-requests route: the layout hides the strip there, and the pull-requests toolbar and shared work-item detail header carry the window-drag filler leaves. Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb * fix(desktop): register pull-requests-filter-state in the persisted-key registry Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb --------- Co-authored-by: Satya Patel <satyapatel111@gmail.com>
Summary
Why / Context
When the expanded v2 sidebar sits outside the TopBar column, the sidebar header already hosts the traffic-light pad, sidebar toggle, and nav controls — leaving the TopBar with nothing to show on these routes. The workspace detail and new-workspace routes already hid it; these three views were the remaining places showing the dead strip.
How It Works
_dashboard/layout.tsxextendshideTopBarto/automations,/tasks, and/v2-workspaces(fuzzy, so detail pages match too), gated onsidebarOutsideColumn. With the sidebar collapsed or closed the TopBar still renders, since it then carries the toggle, nav controls, and traffic-light inset.dragfiller leaf so the window stays draggable across the top, following the drag-on-empty-leaves rule.Manual QA Checklist
Verified end-to-end over CDP against the dev app (signed-in session, expanded v2 sidebar), navigating by real clicks on the sidebar buttons:
Testing
bun run lintbun run typecheck(desktop)https://claude.ai/code/session_015PEPRDMRZobovARaZiBHgd
Summary by cubic
Fixes an empty 48px top strip on Automations, Tasks, and Workspaces in the v2 desktop dashboard. The TopBar is now hidden on these routes when the expanded sidebar hosts the window controls, so headers sit flush with the top.
/automations,/tasks, and/v2-workspaces(fuzzy) whensidebarOutsideColumnis true.Written for commit 4787b8f. Summary will update on new commits.
Summary by CodeRabbit