Skip to content

fix(desktop): remove empty top strip on automations, tasks, and workspaces views - #6023

Merged
AviPeltz merged 1 commit into
mainfrom
spangle-echinodon
Jul 29, 2026
Merged

AviPeltz merged 1 commit into
mainfrom
spangle-echinodon

Conversation

@AviPeltz

@AviPeltz AviPeltz commented Jul 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • On the v2 dashboard with the expanded sidebar, the TopBar rendered as a completely empty 48px strip above the Automations, Tasks, and Workspaces views. It's now hidden there, so each view's header sits flush with the window top.

Why / Context

When the expanded v2 sidebar sits outside the TopBar column, the sidebar header already hosts the traffic-light pad, sidebar toggle, and nav controls — leaving the TopBar with nothing to show on these routes. The workspace detail and new-workspace routes already hid it; these three views were the remaining places showing the dead strip.

How It Works

  • _dashboard/layout.tsx extends hideTopBar to /automations, /tasks, and /v2-workspaces (fuzzy, so detail pages match too), gated on sidebarOutsideColumn. With the sidebar collapsed or closed the TopBar still renders, since it then carries the toggle, nav controls, and traffic-light inset.
  • Each affected header (Automations list + detail, Tasks top bar + task/issue/PR detail, Workspaces) gains an empty drag filler leaf so the window stays draggable across the top, following the drag-on-empty-leaves rule.

Manual QA Checklist

Verified end-to-end over CDP against the dev app (signed-in session, expanded v2 sidebar), navigating by real clicks on the sidebar buttons:

  • Automations: header renders at window top, no 48px bar in the DOM
  • Tasks: TasksTopBar renders at window top
  • Workspaces: header h1 at top, no bar
  • Baseline (pre-fix boot state) showed the empty TopBar strip above these views
  • Collapsed/closed sidebar still shows the TopBar with toggle + nav (code-path only, not exercised live)
  • Window dragging from the header filler areas (drag regions can't be exercised via CDP)

Testing

  • bun run lint
  • bun run typecheck (desktop)

https://claude.ai/code/session_015PEPRDMRZobovARaZiBHgd


Open in Stage

Summary by cubic

Fixes an empty 48px top strip on Automations, Tasks, and Workspaces in the v2 desktop dashboard. The TopBar is now hidden on these routes when the expanded sidebar hosts the window controls, so headers sit flush with the top.

  • Bug Fixes
    • Hide TopBar on /automations, /tasks, and /v2-workspaces (fuzzy) when sidebarOutsideColumn is true.
    • Keep TopBar when the sidebar is collapsed or closed to show the toggle, nav, and traffic-light inset.
    • Add drag filler elements to each view header to keep the window draggable.

Written for commit 4787b8f. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • UI Improvements
    • Improved window dragging across automation, task, issue, pull request, and workspace views.
    • Updated dashboard layouts to provide consistent draggable header areas when the top bar is hidden.
    • Preserved existing header actions, search, filters, navigation, and workspace controls.

…paces views

With the expanded v2 sidebar hosting the traffic lights and nav, the
TopBar rendered as a fully empty 48px strip above these views. Hide it
there (matching the workspace and new-workspace routes) and add
window-drag filler leaves to each view's own header so the window stays
draggable.

Claude-Session: https://claude.ai/code/session_015PEPRDMRZobovARaZiBHgd
@ghost

ghost commented Jul 28, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 4 individual chapters for you:

Title
1 Define logic to hide TopBar on dashboard views
2 Add window-drag regions to Automations headers
3 Add window-drag regions to Tasks headers
4 Add window-drag region to Workspaces header
Open in Stage

Chapters generated by Stage for commit 4787b8f on Jul 28, 2026 8:22pm UTC.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e4f46cce-bef6-42db-bda9-c836f8ccb0db

📥 Commits

Reviewing files that changed from the base of the PR and between 9613221 and 4787b8f.

📒 Files selected for processing (8)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/$automationId/components/AutomationDetailHeader/AutomationDetailHeader.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/layout.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/$taskId/components/TaskDetailHeader/TaskDetailHeader.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/components/TasksView/components/TasksTopBar/TasksTopBar.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/issue/$issueNumber/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/pr/$prNumber/page.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspaces/components/V2WorkspacesHeader/V2WorkspacesHeader.tsx

📝 Walkthrough

Walkthrough

Dashboard routes now hide the TopBar across additional views and render draggable placeholder regions in automation, task, issue, pull request, and workspace headers.

Changes

Dashboard TopBar drag regions

Layer / File(s) Summary
Dashboard TopBar visibility
apps/desktop/src/renderer/routes/_authenticated/_dashboard/layout.tsx
Adds dashboard route detection and expands hideTopBar handling when the sidebar is outside the TopBar column.
Automation and workspace drag regions
apps/desktop/src/renderer/routes/_authenticated/_dashboard/automations/..., apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspaces/...
Adds draggable placeholder elements to automation and workspace headers.
Task drag regions
apps/desktop/src/renderer/routes/_authenticated/_dashboard/tasks/...
Adds draggable placeholder elements to task list, task detail, issue, and pull request headers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: kitenite

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main fix: hiding the empty top strip on the affected desktop dashboard views.
Description check ✅ Passed The description covers the problem, rationale, implementation, testing, and checklist items, so it is mostly complete.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spangle-echinodon

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AviPeltz
AviPeltz merged commit 82bae22 into main Jul 29, 2026
11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

saddlepaddle added a commit to Roshvan/superset that referenced this pull request Aug 3, 2026
…ests views

Extends the hidden-TopBar treatment from ParadevAI#6023 to the new /pull-requests
route: the layout hides the strip there, and the pull-requests toolbar and
shared work-item detail header carry the window-drag filler leaves.

Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb
saddlepaddle added a commit that referenced this pull request Aug 4, 2026
* feat(desktop): separate tasks and pull requests in sidebar

* fix(desktop): re-measure task title height on text change, drop dead stored-search seed

Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb

* fix(desktop): hide the empty TopBar and keep window drag on pull-requests views

Extends the hidden-TopBar treatment from #6023 to the new /pull-requests
route: the layout hides the strip there, and the pull-requests toolbar and
shared work-item detail header carry the window-drag filler leaves.

Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb

* fix(desktop): register pull-requests-filter-state in the persisted-key registry

Claude-Session: https://claude.ai/code/session_01WPvjzEZjYWFoedQUiCKBPb

---------

Co-authored-by: Satya Patel <satyapatel111@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant