Repository navigation
fix(desktop): match workspace pane tab borders to right sidebar tabs - #6281
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe tab bar now applies bottom borders to its layout regions. Active tabs use transparent bottom borders with visible side and top borders. Inactive tabs preserve the bottom border. Tab interaction and drag/drop behavior remain unchanged. ChangesTab border styling
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview Deployment🔗 Preview Links
Preview updates automatically with new commits |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How It Works
TabItem.tsx: active tab getsborder border-border border-b-transparent bg-background; inactive tabs getborder border-transparent border-b-border. All states keep a 1px border on every side so tabs don't shift when switching.TabBar.tsx: every non-tab region (leading chrome, add-tab button slot, drag filler, overflow add button, trailing controls) carriesborder-b border-borderso the line spans the full bar width. The border lives on each region rather than the bar root, because a root-levelborder-bwould draw a line under the active tab and break the blend-into-content effect.Testing
bun run lint(clean)tsc --noEmitinpackages/panes(clean)Summary by cubic
Match workspace pane tab borders to the right sidebar style. Active tabs now flow into content; the bottom border stays continuous under inactive tabs and non-tab regions.
TabItem.tsx, active tabs useborder border-border border-b-transparent bg-background; inactive tabs useborder border-transparent border-b-borderto avoid layout shift.TabBar.tsx, addborder-b border-borderto non-tab regions (leading area, add-tab slots, drag filler, overflow add button, trailing controls) so the bottom line spans the full width.Written for commit 780924e. Summary will update on new commits.