Repository navigation
Bump react-dom from 18.3.1 to 19.2.0 - #1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
6 times, most recently
from
October 25, 2025 21:31
6434ff2 to
8883acf
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 03:23
8883acf to
265b8fc
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 03:39
265b8fc to
b10d6b6
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 03:41
b10d6b6 to
331f1d7
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 20:30
331f1d7 to
82ea50b
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 20:53
82ea50b to
cbd6f25
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 22:41
cbd6f25 to
89925be
Compare
Bumps [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) from 18.3.1 to 19.2.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.0/packages/react-dom) --- updated-dependencies: - dependency-name: react-dom dependency-version: 19.2.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-dom-19.2.0
branch
from
October 27, 2025 23:59
89925be to
c4ddf19
Compare
Contributor
Author
|
Looks like react-dom is no longer updatable, so this is no longer needed. |
4 of 5 tasks
This was referenced Jul 8, 2026
Closed
AlexGodard
added a commit
to AlexGodard/superset
that referenced
this pull request
Jul 20, 2026
…t session (ParadevAI#1) New 'superset agents send <sessionId> <text...> --workspace <id>' command calls the existing terminal.writeInput mutation, appending LF iff absent (mirrors normalizeTerminalCommand) so the message renders live in the desktop session. No backend changes.
This was referenced Jul 22, 2026
9 tasks done
This was referenced Aug 10, 2026
caiokf
added a commit
to caiokf/superset
that referenced
this pull request
Aug 12, 2026
A file dropped on a v1 terminal pane was written straight to the PTY, so the foreground app saw it as typing. Agent TUIs use the bracketed-paste envelope to tell a dropped path apart from a typed one, so the path was left as literal text and the image was never attached (ParadevAI#6370). Measured against Claude Code 2.1.215 in a real PTY (tmux, 120x45, path `/tmp/drop-probe/scratch/My Screenshot.png`, file present on disk): single-quoted + bracketed paste -> [Image ParadevAI#1] backslash-esc. + bracketed paste -> [Image ParadevAI#1] single-quoted + typed -> literal text backslash-esc. + typed -> literal text The delivery is what decides it; the escaping style makes no difference. v2 panes already call xterm's paste(), and so does Cmd+V in a v1 pane — route the drop through the same call.
This was referenced Aug 14, 2026
This was referenced Aug 24, 2026
Closed
saddlepaddle
added a commit
that referenced
this pull request
Sep 6, 2026
… route to the diff Every navigation to files-changed comes from PullRequestScreen, so without a pull request the diff is unreachable — and "review the diff from your phone" is what the store listing promises. It had been unreachable since this box was rebuilt. The cause was setup.sh creating the demo repos with `git init`. The original /demo/acme was a clone of the public superset-sh/acme-demo, whose open PR #1 matches the fix-input-overflow workspace. A fresh init produced unrelated history, no origin, and no refs/remotes/origin/HEAD — which also silently broke the diff base, since getDefaultBranchName reads exactly that ref. setup.sh now clones, so the PR and the diff base both come back on their own rather than from refs fabricated to paper over the init. The host also needs a token: ctx.github() throws NO_GITHUB_TOKEN rather than falling back to unauthenticated, even on a public repo. A fine-grained public-repositories read-only PAT lives in /etc/superset-review-host.env (0600, root), read through EnvironmentFile=- so it stays out of world-readable unit files, out of `gh auth login`, and out of the worktrees. That PAT expires 2026-10-05, and an expired one removes the headline feature without any other symptom, so check.sh calls the GitHub API with it every run and fails loudly. The README carries the rotation command. Verified on device: home shows diff stats per row, the chip renders in the quick-key bar, and it opens PR #1 through to a syntax-highlighted two-file diff. Claude-Session: https://claude.ai/code/session_0126YNrKGh5P6h9a2S9j1YAj
saddlepaddle
added a commit
that referenced
this pull request
Sep 6, 2026
… on expired credentials (#7216) * fix(review-host): give the reviewer a diff to review, and stop paging on expired credentials Two things found driving the app as the reviewer sees it. The store listing promises "review the diff from your phone" and every demo workspace had an empty diff. Two separate causes. The worktrees were rebuilt as bare branches during the GCP move, so there was nothing committed on them; each now carries one small change matching its name. And the demo repos are created by `git init`, so they have no refs/remotes/origin/HEAD — getDefaultBranchName reads exactly that ref, returns null, resolveBaseComparison gives up, and listCommits returns [] no matter what is on the branch. They were clones before this box was rebuilt, which is why nobody had seen it. setup.sh now fabricates origin/main and origin/HEAD locally; there is no remote to fetch and nothing tries, so the base resolves offline. check.sh asserts every demo workspace has a diff, because an empty one is a listing mismatch rather than a cosmetic gap, and it has now been empty twice for different reasons. check.sh also exits 2 with INCONCLUSIVE when gcloud cannot authenticate, instead of reporting the instance as missing. Every probe runs through gcloud, so an expired refresh token made a healthy box look down — and the automation pages someone for a down box. It found this the honest way: the token expired mid-session. Claude-Session: https://claude.ai/code/session_0126YNrKGh5P6h9a2S9j1YAj * feat(review-host): restore the pull-request chip, the reviewer's only route to the diff Every navigation to files-changed comes from PullRequestScreen, so without a pull request the diff is unreachable — and "review the diff from your phone" is what the store listing promises. It had been unreachable since this box was rebuilt. The cause was setup.sh creating the demo repos with `git init`. The original /demo/acme was a clone of the public superset-sh/acme-demo, whose open PR #1 matches the fix-input-overflow workspace. A fresh init produced unrelated history, no origin, and no refs/remotes/origin/HEAD — which also silently broke the diff base, since getDefaultBranchName reads exactly that ref. setup.sh now clones, so the PR and the diff base both come back on their own rather than from refs fabricated to paper over the init. The host also needs a token: ctx.github() throws NO_GITHUB_TOKEN rather than falling back to unauthenticated, even on a public repo. A fine-grained public-repositories read-only PAT lives in /etc/superset-review-host.env (0600, root), read through EnvironmentFile=- so it stays out of world-readable unit files, out of `gh auth login`, and out of the worktrees. That PAT expires 2026-10-05, and an expired one removes the headline feature without any other symptom, so check.sh calls the GitHub API with it every run and fails loudly. The README carries the rotation command. Verified on device: home shows diff stats per row, the chip renders in the quick-key bar, and it opens PR #1 through to a syntax-highlighted two-file diff. Claude-Session: https://claude.ai/code/session_0126YNrKGh5P6h9a2S9j1YAj * feat(review-host): give acme-ios a pull request too, and clone both demo repos The pull-request chip is the only navigation to files-changed, so a project without a PR has no route to the diff at all — and diff review is what the store listing promises. acme had one through superset-sh/acme-demo; acme-ios had no GitHub repository, so half the reviewer's projects were a dead end. Adds superset-sh/acme-ios-demo (public, same shape as acme-demo: a composer, a test, and an open PR adding haptics) and clones it alongside acme. Both demo projects now carry one PR-linked workspace and two with a diff but no PR, which is what a real project looks like. Cloning also retires the workaround underneath. setup.sh used to `git init` the demo repos and then fabricate refs/remotes/origin/main and origin/HEAD so the diff base could resolve; a clone brings both refs, the branches, and the PR without inventing anything. The vendored demo/ copy and its biome exclusion go with it — it had already drifted from the real repositories, which is how the two got out of step. check.sh now asserts at least one workspace has a linked pull request. Every other check can pass while the chip is gone, and the chip is the whole path to the feature the listing sells. Verified end to end on device for both projects, and setup.sh re-run to confirm it stays idempotent against existing clones. Claude-Session: https://claude.ai/code/session_0126YNrKGh5P6h9a2S9j1YAj * fix(review-host): re-clone a legacy demo repo, and keep ids and tokens off the remote command line Three from the bot reviews on this branch, all real. setup.sh guarded the demo clone on `.git` existing, so a host provisioned by the earlier version — where the repos were `git init`ed and their refs fabricated — would keep those forever: no origin, no PR, no diff base, which is the exact state this branch replaced. The guard is now the origin URL, so a legacy repo is re-cloned and a correct one is only fetched. check.sh interpolated workspace ids into commands a remote shell parses. workspace.adopt takes an unrestricted existingWorkspaceId, so the host database is not a trusted source of shell-safe strings. Ids that are not plain uuids are dropped — and because dropping one silently would hide a workspace from every probe below, which is the fail-open shape this script keeps getting wrong, dropping any is itself a failure. The README's rotation command passed the PAT as an argument, which lands in local shell history and in ps output and auth logs on the box. It goes over stdin now. Also asserts both demo projects have a linked pull request rather than at least one: with a PR per project, one link surviving means the other project has no route to a diff at all, and check.sh was reporting that as fine. The token probe covers both repositories for the same reason. Verified on the live box: setup.sh re-run leaves both clones with the right origin and origin/HEAD, and check.sh passes all twelve assertions. Claude-Session: https://claude.ai/code/session_0126YNrKGh5P6h9a2S9j1YAj
4 of 5 tasks
5 of 6 tasks
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-dom from 18.3.1 to 19.2.0.
Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
8618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)5667a41Bump next prerelease version numbers (#34639)e08f53bMatchreact-dom/statictest entrypoints and published entrypoints (#34599)8bb7241Bump useEffectEvent to Canary (#34610)83c88adHandle fabric root level fragment with compareDocumentPosition (#34533)68f00c9Release Activity in Canary (#34374)3168e08[flags] enable opt-in for enableDefaultTransitionIndicator (#34373)3434ff4Add scrollIntoView to fragment instances (#32814)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)