Skip to content

[CodeStyle][py2] remove paddle.compat - #47269

Merged
luotao1 merged 5 commits into
PaddlePaddle:developfrom
cattidea:py2/fix/compat-clean-all
Oct 25, 2022
Merged

luotao1 merged 5 commits into
PaddlePaddle:developfrom
cattidea:py2/fix/compat-clean-all

Conversation

@SigureMo

Copy link
Copy Markdown
Collaborator

PR types

Others

PR changes

Others

Describe

清理 compat 模块的最后一步,彻底清理掉 paddle.compat 模块、单测以及一些 unused imports

Related links

@paddle-bot

paddle-bot Bot commented Oct 23, 2022

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@SigureMo SigureMo changed the title [WIP][CodeStyle][py2] remove paddle.compat [CodeStyle][py2] remove paddle.compat Oct 23, 2022

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

PR-CI-Coverage 和 PR-CI-Mac-Python3 由于移除单测 test_compat 挂掉了,已经按照说明在 https://github.com/PaddlePaddle/Paddle/wiki/Temporarily-disabled-Unit-Test 说明了理由

sgd.load(state_dict)
except NotImplementedError as e:
print(cpt.get_exception_message(e))
print(e)

@SigureMo SigureMo Oct 23, 2022 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一处 API 文档变动:移除了一个示例代码的 compat 模块的使用,为通过示例代码运行添加了 enable_static

@luotao1 luotao1 self-assigned this Oct 24, 2022

@luotao1 luotao1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XieYunshen XieYunshen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jzhang533

Copy link
Copy Markdown
Contributor

🎆 🎆 🎆

https://github.com/PaddlePaddle/docs/tree/develop/docs/api/paddle/compat

这个目录也可以删除了。

@SigureMo

SigureMo commented Oct 24, 2022 •

Copy link
Copy Markdown
Collaborator Author

这个目录也可以删除了。

嗯嗯,之后我在 docs 那边一起清理下(API 文档 + 其余文档中的相关使用等等)~

UPDATE:

见 PaddlePaddle/docs#5376

@luotao1
luotao1 merged commit ea8e87f into PaddlePaddle:develop Oct 25, 2022
@SigureMo
SigureMo deleted the py2/fix/compat-clean-all branch October 25, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants