Repository navigation
[CodeStyle][py2] remove compat module (to_text) - #47036
Merged
Merged
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
This reverts commit a6b69cb8dca8b9b031ce10ea32d1040e7e0dd267.
SigureMo
force-pushed
the
py2/fix/compat-part4
branch
from
October 15, 2022 12:56
a6b69cb to
a38258d
Compare
SigureMo
changed the title
compat module (to_text)compat module (to_text)
Collaborator
请解决下冲突。可以直接把函数/单测清理了，因为 #46965 已经冲突了。 |
Collaborator
Author
冲突已解决，不过这里没有清理函数和单测还有另外一个原因，是因为完全清理后将会到达 30+ 文件（除去函数单测两个文件还有一些 fluid 下的 import），需要额外的 Approve，如果拆成两个 PR 则可以避开这一问题 |
luotao1
approved these changes
Oct 18, 2022
This was referenced Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
清理
compat模块的第四步（to_text函数）同
to_bytes，to_text函数本身和单测暂未清理，在之后 PR 清理Related links
compatpart1: [CodeStyle] remove compat module (long_type, int_type, get_exception_message, floor_division) #46686compatpart2: [CodeStyle][py2] remove compat module (round) #46923compatpart3: [CodeStyle][py2] removecompatmodule (to_bytes) #47035